Repository navigation
fix(subtitles): respect verified non-HI provider metadata - #789
Draft
metoocrib-lang wants to merge 1 commit into
Draft
metoocrib-lang wants to merge 1 commit into
metoocrib-lang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a Provider Hub candidate explicitly marked as verifiable non-HI can
change its destination from
episode.es.srttoepisode.es.hi.srtwhen ordinarydialogue contains parentheses. This may also target an existing HI file.
Honor
hearing_impaired_verifiable is Truetogether with_reported_hearing_impaired is Falsebefore applying the content heuristic.This applies to any provider carrying those facts. Missing, unverified or
malformed metadata retains the heuristic; existing HI language flags and
explicit
remove_HIbehavior remain unchanged.The regression test runs the actual saver and regex functions extracted from
its AST, with in-memory destinations. Register it in the Backend suites CI
step so the test is collected on future pull requests.
Validation
Base:
development, commiteffe5a9cc6e21910ab659ab41e0481479aa5b5f0.the two expected failures for verified normal subtitles; the other nine
scenarios pass.
custom_libs;git diff --checkalso passes.--noconftest) of the regression and CI guard:236 passed, 7 failed. The failures concern one omitted sparse-checkout file,
Windows symbolic-link privileges, and five PostgreSQL guard subprocesses
missing SQLAlchemy in the minimal environment. The new test registration
passes the guard. This is not a passing full CI run.
services or library files were changed. Please keep this proposal in draft
until full CI has completed successfully.