Skip to content

Buddy's chat: own messages around a hidden Delegace wake-up do not merge into one bubble #156

Open

Description

@immakermatty

What

Upstream v0.1.5 and v0.1.6 merge consecutive own messages into one bubble and show one steer label for a run of steers (pingdotgg#27305, pingdotgg#27978). MessagesTimeline.logic.ts:2150-2152 computes groupedWithNext and continuesSteer from the neighbouring rows, before row 27 hides Delegace's wake-ups (visibleActingSenderRows).

A hidden wake-up is never an own message itself (it is attribution === "agent"), but it separates its neighbours. After it is hidden, two own messages around it stand next to each other as two separate bubbles, and if both are steers, each has its own steer label.

Impact

Cosmetic. No message or label is lost. Not verified in a browser.

Fix

Hide the rows before upstream derives the grouping, or recompute the grouping after the filter. Both add a new seam in upstream's timeline logic, so this stayed out of the rebuild.

Found during the v0.1.6 rebuild (#148, row 27).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions