Adds two randomized equivalence oracles based on the W method - #40
Merged
Conversation
Maybe it is a good time to add better support for testing oracles
Contributor
Author
|
See #41 for some thought on testing equivalence oracles. |
Contributor
|
I would like to keep the naming of the classes consistent for now. If we remove the suffix "EQOracle", we would have to do it everywhere and would end up with things like "new SampleSet(...)" and this does not really reveal what the class is doing. Beside that, I don't see a reason why this should not be merged. |
Contributor
Author
|
I renamed the classes to end on EQOracle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my implementation of the randomized W/Wp method. It is more successful in finding counter examples than the current W/Wp methods in learnlib, but they do not provide any completeness guarantees. (Of course it is also more efficient than just a random walk.)
I have some concerns with the current state of affairs. In particular I found it annoying that I had to implement execution of tests and a bound in each equivalence oracle. I think that this can be decoupled, in order to make more generic testing oracles which can be reused. I will open a separate issue to discuss this.
In the meantime, this patch works, and provides a nice utility. I noticed that it is not consistent with the current naming, but I don't really like the current naming (all oracles ends with
EQracle...)