rvvm: Restart the eventloop thread after it stops on its own - #326
Open
BeastLe9enD wants to merge 1 commit into
Open
BeastLe9enD wants to merge 1 commit into
BeastLe9enD wants to merge 1 commit into
Conversation
When the last running machine powers off, the eventloop thread finds no machines left and returns, but eventloop_thread keeps pointing at it. The next rvvm_start_machine() sees a thread handle and does not create a new one, so the restarted machine runs without an eventloop: hart timers are not checked, devices are not updated and a later power-off is never processed. The machine then stays running with its power state off, and every further rvvm_start_machine() fails. Record under global_lock that the threaded eventloop exited by itself and let rvvm_reconfigure_eventloop() join that thread before deciding whether to create a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the last running machine powers off, the eventloop thread finds no machines left and returns, but eventloop_thread keeps pointing at it. The next
rvvm_start_machine()sees a thread handle and does not create a new one, so the restarted machine runs without an eventloop: hart timers are not checked, devices are not updated and a later power-off is never processed. The machine then stays running with its power state off, and every further rvvm_start_machine() fails.Record under global_lock that the threaded eventloop exited by itself and let
rvvm_reconfigure_eventloop()join that thread before deciding whether to create a new one.Oh and I apologize for the PR spam of course 😆