Conversation
Model: gpt-5.6-sol
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #832
Problem / pressure
The existing Pi migration rewrites each eligible
registry/pi-acpprovider in place. That changes the launch implementation behind the provider's stable identity, so customized commands, environments, and existing session bindings no longer mean what the user configured.Summary
builtin/piprovider per machine through an atomic insert-if-absent write, preserving an existing managed row on retries or concurrent clicks.PI_CODING_AGENT_DIRprofile boundary, and update the owning draft Specs and bilingual decision notes.Visual explanation
flowchart LR L[Self-managed registry/pi-acp] -->|remains unchanged| S[Existing sessions] A[Explicit Add managed Pi] --> C{builtin/pi exists?} C -->|No| N[Atomic insert with stable machine ID] C -->|Yes| K[Keep existing managed row] N --> P[Managed Pi selectable for new sessions] K --> PBefore / after
Test plan
Passed:
@lody/shared:vitest run tests/pi-provider-migration.test.ts— 3 passed.@lody/components:vitest run tests/agent-config-create.test.ts— 2 passed.@lody/shared:tsgo --noEmit— passed.oxfmt --check— passed.pnpm run lint:i18n— passed.git diff --check— passed.Known local failures:
@lody/components:tsgo --noEmitfailed in this partial checkout while resolving unavailable Electron and workspace dependencies, includingelectron,electron-ipc-decorator, and@lody/shared/*entry points. It did not provide a usable full components typecheck result.pnpm run docs checkfailed because ACP submodules are not initialized in this worktree, leaving existing links intopackages/acp-extension-codexandpackages/acp-extension-grokunresolved.Context handoff
Original user prompt
Show original prompt
Authorized scope completion: follow #832 and implement the issue's add-not-replace boundary while preserving legacy provider identity, configuration, environment, and existing session bindings; keep registration idempotent and scope the explicit action to the selected capable machine.
Shared conversation
Status: unavailable
Reason: This authoring environment does not provide a public HTTP(S) conversation URL. No private conversation content is included in this PR.