Conversation
Route replayed child history through the negotiated subagent event bridge so Lody receives the same lifecycle and output envelope as live turns. Model: gpt-6-sol
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Lody and Codex negotiate
subagentEventsv1, live child activity passes through the adapter’s normalized event bridge. Restoring a Codex thread instead streamedsubagent_spawnedandsubagent_state_updatedirectly through the raw ACP connection. Lody’s receiver rejects those variants withInvalid params(LodyAI/Lody#1108).Change
Route restored child history through the existing per-session bridge. Negotiated Lody clients receive root-owned snapshot and output events; clients using native ACP child sessions keep their existing transport. The load-session fixture now checks both modes, including restored output and a disconnected child.
Validation
npm test -- --run src/__tests__/CodexACPAgent/load-session.test.ts: 9 passed.npm run typecheckandnpm run build: passed.npm testwas attempted and interrupted after 14 failures inCodexAcpClient.test.tsandmcp-config-merge.test.ts; a representative Codex initialization failure (Codex process has exited with code 1) also reproduces on the unchanged base commit0d7bb30. The remaining failures were not classified, so full-suite success is not claimed.The issue’s exact UI effect was not independently verified; this patch addresses the observed protocol rejection on restoration.