Make auto require disabled by default

[Nelvin]

Would it be possible to make auto require disabled by default?

Over the past few days I wondered multiple times why I had a require at the top of a file but guessed it was there because I copy & pasted the file header form existing files. But right now I noticed the same require added to a 3rd party library (rxi/flux) after I've just done a very minor code modification to the file. The auto require is completely useless as nothing of the required file is ever used in the library.

IMO it's really not a good idea to have content/code modifying features enabled by default.

[sumneko]

Only when your input is neither a defined global variable nor a visible local variable, Auto Require will work, which should eliminate most of the ambiguity.
How do you trigger Auto Require ?

[Nelvin]

I didn't trigger it, well at least not as far as I know (is there a predefined shortcut?). I didn't even know the features exists before I noticed that it inserted a require in some of my files. I only really noticed that something went wrong when it added the line

local tutorial_01 = require "source.tutorial_01"

at the top of the flux.lua file (https://github.com/rxi/flux) which, is a self contained single file library not relying on any external code/data (besides some math functions) and even less so a tutorial script from my game :)

The only change I did to flux.lua was to add a single line after line 170 with the following content
t.done = true

I have no idea why the auto require happened or, in case I did trigger it, how I did it :)
Anyway - found the toggle to disable features so no real problem on my side but I'd prefer such features to be disabled by default in a language as dynamic as Lua.

[Cassolette]

Auto require is a pretty common feature afaik, it even exists and is enabled by default in VSCode's built-in intellisense for a similarly "dynamic" language, Javascript. If this feature were to be disabled by default, I wouldn't have known that it existed and requiring files in a huge project would continue to be a dreadful task.

It's good to provide context of your environment/setup as it gets hard to find out if it's an issue on your end or with the plugin. I think any specific examples like you just did to reproduce your issue will be more helpful to improve the feature rather than "disable this x feature so it is never known to humankind because it doesn't work well enough"

Anyway, I think this is a separate issue indeed with some edge case involving tables and functions. Could reproduce by having this in a workspace (feel free to make a new issue):

testlib.lua

--- Testlib
local testlib = {}
return testlib

reproduce.lua

local has_function = { f = function () end }

local no_function = { f = true }

-- Doesn't work
do
    local t = has_function[#has_function]
    -- type "t." here
end

-- Works
do
    local t = no_function[#no_function]
    -- type "t." here
end

Version: 1.21.2 (Windows)