Loading workspace in `2.6.0` became really slow

[FlashHit]

I have 3 workspaces in one project with 2500+ files each (because of libraries). Before this release it was loading the workspaces pretty fast. Now it is really really slow. I would say it became unusable for me. So rn I have to roll back to the previous release.

[ur4ltz]

I have exactly the same problem!

[sumneko]

Previously I would start a process per workspace, now I have one process for all workspaces.
With no duplicate files, you should now have around 3x the loading time.
If this is indeed the case, then I might need to consider loading files in multiple threads.
If the actual loading time is much more than 3 times the original, then there should be other bugs that need to be resolved as soon as possible.

[FoolHen]

Same here, it seems to be way more than 3 times. It usually takes less than a minute, now I've measured 12 minutes. That said, automatically detecting and processing all workspaces is a nice addition, having to open a file from each workspace before was a bit annoying. 👍

[sumneko]

Same here, it seems to be way more than 3 times. It usually takes less than a minute, now I've measured 12 minutes. That said, automatically detecting and processing all workspaces is a nice addition, having to open a file from each workspace before was a bit annoying. 👍

It does sound like there is a bug causing the loading speed to be too slow, and I'll take that as a priority.
Thanks for your feedback!

[FlashHit]

All 3 workspaces have a library that is the same. Is it now possible to load a library 1 time for all 3 workspaces? Not sure if this is something that could work but this would reduce the size of the files to cache a lot for me.

workspace 1 libraries: fb, shared, client
workspace 2 libraries: fb, shared
workspace 3 libraries: fb, shared, server

it’s looks a bit like this now and it’s the fb library that has over 2000 files.

[sumneko]

Please check if this version works: https://github.com/sumneko/lua-language-server/actions/runs/1711860828

[Sedas25]

@sumneko that version is much faster

[FlashHit]

Still slow for me

[sumneko]

Still slow for me

Please provide your logs, see https://github.com/sumneko/lua-language-server/wiki/Default-log-path

[FoolHen]

@sumneko Takes longer for me than 2.6.0, took around 30 min. Diagnosing workspace is what takes most of it. Loading workspace was around 4 min.
Log

[sumneko]

Sorry I've been busy these days, this issue may take next week to resolve

[sumneko]

Please check if this version works: https://github.com/sumneko/lua-language-server/actions/runs/1728033602

[FoolHen]

@sumneko Still the same issue, log. This time it took around 15 min.