fix: add a missing check for 'inject-field' diagnostics#2747
Merged
Conversation
NeOzay
commented
Jul 8, 2024
Contributor
|
Glad that you finally find a proper way to fix it 😄 And as @C3pa mentioned here, I tested your fix on a few similar issues and all of them are cleared now! One stone three birds! 🎉
In your PR description, instead of Only then can properly link the pull request to those issues, and leverage the github's close issue on PR merge function. It requires the keywords (in your case is the word |
This was
linked to
issues
Jul 9, 2024
Collaborator
|
@tomlau10 Thanks for mentioning all the fixed issues! Helps a bunch with organization! I linked them to this PR 🙂. |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix related to #2746