Repository navigation
docs(run.sh): describe TEST_SEGMENT_SET in the segment comment - #64
Merged
Merged
Conversation
The comment above SEGMENTED_SUITES still said TEST_SEGMENTS sets how many processes share the work, which no longer matches the implementation or the README. State the segment count and point TEST_SEGMENT_SET at the per-job selection. Comments only; no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment above
SEGMENTED_SUITESintests/run.shstill said thatTEST_SEGMENTSsets how many processes share the work. Since #63 the suite source is cut into a fixed number of segments and each job selects a subset, so the comment no longer matches the implementation (nor README lines 30–32). This rewords the comment: segment count per suite,TEST_SEGMENT_SETas the per-job selection, andTEST_SEGMENTS=1as the single-process whole-suite run.Scope
In scope: the comment block above
SEGMENTED_SUITESintests/run.shonly (3 lines → 4 lines).Out of scope: no code logic, no workflow matrix or job definitions, no README, no other files, no incidental refactor.
git difftouchestests/run.shcomments only.Validation
bash -n tests/run.sh→ rc 0bash tests/test-shards.sh→ rc 0 (All shard fixture tests passed.)bash tests/test-lint-coverage.sh→ rc 0Run locally on an iSH copy of the tree (tar pipe to
/tmp); full suite delegated to this PR's CI as usual.Risks
None expected: comments only, no behaviour change. Comment text stays within 80 columns and matches README's wording.
Rollback
git revertof the single commit; no data or state involved.