Repository navigation
fix: wrap getServerInfo response in MediaContainer - #148
Sierra1011 wants to merge 1 commit into
Conversation
Real PMS wraps the GET / JSON response in a MediaContainer key, as workflows/server-health-check.yaml assumes ($response.body.MediaContainer.machineIdentifier). Verified against PMS 1.43.5.11029-6bf8af3f0, the current public release.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
@LukasParke any chance of this being actioned? Thanks. |
Summary
Fixes #147. Restores the wrapper dropped in #117.
getServerInfo(GET /) 200 response schema under aMediaContainerkey, keeping the richerServerConfigurationschema andDirectorylist from feat: Integrate Arbiter discovery pipeline #117 inside it.Validation
GET /on PMS 1.43.5.11029-6bf8af3f0 returns the configuration and all 25Directoryentries insideMediaContainer.npm run validatepassed, with no new warnings.speakeasy lint1.802.0 passed, with no new warnings.Summary by CodeRabbit
MediaContainerobject.

Confidence Score: 5/5
No blocking defects were found, and the checked response contract supports merging.Summary
Restores the
MediaContainerwrapper around thegetServerInfosuccess response, keepingServerConfigurationand theDirectorylist inside it and moving the example under the same key. Executed contract checks confirmed that the inner schema and example preserve their previous content and match the health workflow’s existing field paths. Focused formatting and specification/workflow lint checks passed. No actionable issues were found; the checked contract behavior supports merging.T-Rex validation blocked
Evidence upload was unavailable because no upload operation was exposed. Executed scripts and observed output remain available at the local references below, but no uploaded references could be confirmed. A live Plex response was not independently tested because no Plex instance was provisioned.
Reviews (1) · Last reviewed commit: "fix: wrap getServerInfo response in Medi..." · Reviewed by Greptile