Skip to content

fix: wrap getServerInfo response in MediaContainer - #148

Open
Sierra1011 wants to merge 1 commit into
LukasParke:mainfrom
Sierra1011:fix/get-server-info-media-container
Open

Sierra1011 wants to merge 1 commit into
LukasParke:mainfrom
Sierra1011:fix/get-server-info-media-container

Conversation

@Sierra1011

@Sierra1011 Sierra1011 commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

Fixes #147. Restores the wrapper dropped in #117.

  • Nest the getServerInfo (GET /) 200 response schema under a MediaContainer key, keeping the richer ServerConfiguration schema and Directory list from feat: Integrate Arbiter discovery pipeline #117 inside it.
  • Move the example under the same key.

Validation

  • GET / on PMS 1.43.5.11029-6bf8af3f0 returns the configuration and all 25 Directory entries inside MediaContainer.
  • npm run validate passed, with no new warnings.
  • speakeasy lint 1.802.0 passed, with no new warnings.

Summary by CodeRabbit

  • Bug Fixes
    • Updated response formatting so configuration details and directory listings are consistently grouped under a MediaContainer object.

RetriggerView in GreptileConfidence Score: 5/5

No blocking defects were found, and the checked response contract supports merging.

Summary

Restores the MediaContainer wrapper around the getServerInfo success response, keeping ServerConfiguration and the Directory list inside it and moving the example under the same key. Executed contract checks confirmed that the inner schema and example preserve their previous content and match the health workflow’s existing field paths. Focused formatting and specification/workflow lint checks passed. No actionable issues were found; the checked contract behavior supports merging.

T-Rex validation blocked

Evidence upload was unavailable because no upload operation was exposed. Executed scripts and observed output remain available at the local references below, but no uploaded references could be confirmed. A live Plex response was not independently tested because no Plex instance was provisioned.

  • Server info responses put settings and directories inside MediaContainer.

Reviews (1) · Last reviewed commit: "fix: wrap getServerInfo response in Medi..." · Reviewed by Greptile

Real PMS wraps the GET / JSON response in a MediaContainer key, as workflows/server-health-check.yaml assumes ($response.body.MediaContainer.machineIdentifier). Verified against PMS 1.43.5.11029-6bf8af3f0, the current public release.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0f724939-d461-462b-a101-5e1f46f8ec27
📥 Commits

Reviewing files that changed from the base of the PR and between e144d65 and ef0f485.

📒 Files selected for processing: 1
  • plex-api-spec.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The getServerInfo response schema and example now place the server configuration fields and Directory array inside a top-level MediaContainer property.

Changes: Server info response

Layer / File(s) Summary
Wrap the response schema and example
plex-api-spec.yaml
The 200 response schema and example place the existing server configuration and Directory array under MediaContainer.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: jasonlandbridge

Merge Risk: ⚪ Minimal · up to ef0f4

No actionable issue is identified with the response-wrapper change; it is ready for normal validation and merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: wrapping the getServerInfo response in MediaContainer.
Linked Issues check Passed Issue #147 requires the GET / 200 response schema and example to place the existing ServerConfiguration data and Directory list under MediaContainer. The supplied PR evidence states that the s…
Out of Scope Changes check Passed The supplied change summary identifies only the GET / response schema and its example. These changes directly implement issue #147. No unrelated change is demonstrated, sir.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #147 requires the GET / 200 response schema and example to place the existing ServerConfiguration data and Directory list under MediaContainer. The supplied PR evidence states that the schema and example now use this wrapper. The reported validation also confirms 25 Directory entries and configuration data inside MediaContainer. The author reports that npm run validate and speakeasy lint passed.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

If it please you, the wrapper is in place,
Server fields now share a proper space.
The Directory list rests there as well,
The example follows the schema’s spell.
A tidy response, ready to tell.

Comment @coderabbitai help to get the list of available commands.

@Sierra1011

Copy link
Copy Markdown
Author

@LukasParke any chance of this being actioned? Thanks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getServerInfo response is missing the MediaContainer wrapper

1 participant