Repository navigation
Fix interaction plot sampling indices - #836
Open
guillaume-vignal wants to merge 3 commits into
Open
guillaume-vignal wants to merge 3 commits into
guillaume-vignal wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #836 +/- ##
===========================================
+ Coverage 86.37% 86.47% +0.09%
===========================================
Files 115 115
Lines 11958 11966 +8
Branches 2176 2180 +4
===========================================
+ Hits 10329 10347 +18
+ Misses 996 988 -8
+ Partials 633 631 -2
🚀 New features to boost your workflow:
|
milton-minervino
left a comment
Collaborator
There was a problem hiding this comment.
If I understand well the if selection: in get_interaction_values check is the real problem here. Maybe it is worth to check the behaviour with an empty list: with the current code you would get all rows, is that wanted?
If you switch to condition if selection is not None: that would give 0 rows.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
milton-minervino
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #835