Fix Instrument Improvise

[AngeloTadeucci]

Don't send packet to self when broadcasting

Summary by CodeRabbit

• Bug Fixes
  • Modified in-game messaging so that improvisation messages are now delivered only to the intended player's session, preventing unintended broad broadcasts.

[coderabbitai]

Walkthrough

The pull request updates the HandleImprovise method in the InstrumentHandler class by modifying the broadcast call to include the session parameter. This change targets the improvisation message specifically to the player's session rather than broadcasting it globally. The overall method structure and other functionalities within the class remain unchanged.

Changes

File(s)	Change Summary
Maple2.Server.Game/PacketHandlers/InstrumentHandler.cs	Updated HandleImprovise method to broadcast messages with the session parameter, ensuring targeted delivery.

Sequence Diagram(s)

sequenceDiagram
    participant P as Player
    participant IH as InstrumentHandler
    participant S as Session

    P->>IH: Trigger HandleImprovise
    IH->>S: Broadcast improvisation message (with session)
    S-->>IH: Confirm message delivery
    IH-->>P: Process continues

Loading

Possibly related PRs

• Shop Purchase & Field Instruments Fix #307: Involves modifications to the InstrumentHandler focusing on scores and instrument management.
• Music Composing Fixes #253: Pertains to changes in the HandleComposeScore method within InstrumentHandler, impacting instrument handling.

Poem

I'm a rabbit with a hop so light,
Tweaking code to make it right.
Now messages fly with a targeted call,
Ensuring no tune is broadcast to all.
Hoppy bytes and joyful leaps I share,
Celebrating changes with flair!
🐰🎶

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1678b7c and fa9e17c.

📒 Files selected for processing (1)

• Maple2.Server.Game/PacketHandlers/InstrumentHandler.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: format
• GitHub Check: build

🔇 Additional comments (1)

Maple2.Server.Game/PacketHandlers/InstrumentHandler.cs (1)

116-116: LGTM! Prevents echo feedback of improvised notes.

The addition of the session parameter to exclude the originating player from receiving their own improvise packets is correct. This change specifically targets the real-time note data broadcasting, while appropriately maintaining the behavior of other broadcast calls for one-time notifications.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.