Fix Channel Client Lookup

[AngeloTadeucci]

Summary by CodeRabbit

• New Features

  • Enhanced home area interactions with new portal elements and interactive displays based on plot configurations.

• Refactor

  • Streamlined portal transition process for improved user experience.
  • Improved channel monitoring by introducing conditional cancellation of inactive tasks in non-debug builds.
  • Minor code cleanup in the HomeFieldManager class.

[coderabbitai]

Walkthrough

This pull request refines the logic for portal usage and channel monitoring in the game server. In FieldManager.cs, the UsePortal method is simplified to directly migrate sessions using MigrateOutOfInstance for specific portal destinations. Additionally, the HomeFieldManager.cs file sees a minor formatting change with the removal of a blank line. In ChannelClientLookup.cs, the MonitorChannel method is updated to cancel asynchronous monitoring tasks for inactive channels in non-debug builds.

Changes

File(s)	Change Summary
Maple2.Server.Game/Manager/Field/FieldManager/.../FieldManager.cs	Streamlined UsePortal to directly call session.MigrateOutOfInstance for CubePortalDestination.SelectedMap; adjusted handling of CubePortalDestination.FriendHome.
Maple2.Server.Game/Manager/Field/FieldManager/.../HomeFieldManager.cs	Removed a blank line after the Init method.
Maple2.Server.World/Containers/ChannelClientLookup.cs	Updated MonitorChannel to execute CancelAsync on the cancellation token when channels become inactive in non-debug builds.

Possibly related PRs

• Fix: FieldEnterPacket #227: The changes in the main PR to the FieldManager.cs file, specifically the modification of the FieldInstance initialization, are directly related to the changes in the retrieved PR that also modifies the FieldInstance handling in FieldManager.cs.
• Enter Stage simplified & Ensemble condition #310: The changes in the main PR, specifically in the FieldManager.cs file, are related to the modifications in the FieldManager class found in the retrieved PR, which also involves changes to the FieldManager class.
• Feat: Instanced Content Channel #340: The changes in the main PR, specifically the modification of the UsePortal method in FieldManager.cs, are related to the changes in the retrieved PR, particularly the introduction of the MigrateToInstance method.

Suggested reviewers

• Zintixx

Poem

I hopped through fields of code so neat,
Simplifying paths with every beat.
Portals now spring to life with glee,
Inactive channels rest, oh so free!
With joyful hops and a cheerful cheer,
A bunny's delight in changes near! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 047ae8d and fb1b20a.

⛔ Files ignored due to path filters (2)

• Maple2.Server.World/Migrations/20250304061437_InteractCubeFix.cs is excluded by !Maple2.Server.World/Migrations/*
• Maple2.Server.World/Migrations/20250306005429_DungeonInfo.cs is excluded by !Maple2.Server.World/Migrations/*

📒 Files selected for processing (1)

• Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

Maple2.Server.Game/Manager/Field/FieldManager/HomeFieldManager.cs (1)

31-33: Use null-conditional operator for safer portal spawning

Consider using the null-conditional operator to make the code more robust against potential null references.

- foreach (PlotCube cubePortal in cubePortals) {
-     SpawnCubePortal(cubePortal);
- }
+ foreach (PlotCube cubePortal in cubePortals) {
+     if (cubePortal != null) {
+         SpawnCubePortal(cubePortal);
+     }
+ }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62a7aa4 and 67dfd45.

📒 Files selected for processing (3)

• Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs (2 hunks)
• Maple2.Server.Game/Manager/Field/FieldManager/HomeFieldManager.cs (2 hunks)
• Maple2.Server.World/Containers/ChannelClientLookup.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (5)

Maple2.Server.Game/Manager/Field/FieldManager/HomeFieldManager.cs (1)

35-41: Approve handling of life skill cubes

Good implementation for adding field function interactions for life skill cubes. This properly handles special functionality for home fields based on housing categories.

Maple2.Server.World/Containers/ChannelClientLookup.cs (2)

182-184: Approve cancellation for inactive channels in production

Good addition of cancellation handling for inactive channels in non-debug builds. This helps free up resources by stopping monitoring tasks for channels that are no longer active.

---

194-196: Consistent cancellation handling for inactive channels

The cancellation logic is consistently applied in both error handling paths, ensuring that monitoring resources are properly released when a channel becomes inactive.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs (2)

123-123: Approve type-based condition for plot loading

Good use of type checking with this is not HomeFieldManager to ensure plots are only loaded for appropriate field types. This cleanly separates responsibilities between different field manager implementations.

---

412-412: Simplify portal migration process

The code now directly calls session.MigrateOutOfInstance instead of using packet sending and handling, which streamlines the portal usage process and makes the code more maintainable.