Fix: Set Guild Id and Name for PlayerInfoUpdate - #348
Conversation
WalkthroughThe update method in the PlayerInfoUpdateExtensions class was modified to include additional validation. The new logic checks whether the input request contains valid guild information. If a valid GuildId is present, it is assigned to the player's info. Likewise, if a valid GuildName exists in the request, that value is set to the corresponding field in the player's record. There are no changes to the publicly exported entities or their declarations. Changes
Sequence Diagram(s)sequenceDiagram
participant Request as "update.Request"
participant UpdateMethod as "Update()"
participant PlayerInfo as "PlayerInfo"
Request->>UpdateMethod: Call Update with player data
UpdateMethod->>PlayerInfo: Evaluate if GuildId is valid
alt Valid GuildId exists
UpdateMethod->>PlayerInfo: Set PlayerInfo.GuildId
end
UpdateMethod->>PlayerInfo: Evaluate if GuildName is valid
alt Valid GuildName exists
UpdateMethod->>PlayerInfo: Set PlayerInfo.GuildName
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit