Fix: housing

[AngeloTadeucci]

• Fixed issues in the cube portal
• Fixed issues in the planner

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability when accessing player housing plots, reducing the risk of errors when entering or interacting with housing features.
• Refactor
  • Updated internal logic to use a safer method for retrieving player-specific housing plots, enhancing stability and maintainability.
• Enhancements
  • Prevented default plot creation for the home map to streamline housing initialization.
  • Refined map loading to exclude default home maps when no specific owner is provided.

[coderabbitai]

Walkthrough

The changes update several usages of plot retrieval in the housing and field management code. Instead of accessing the first plot in a collection, the code now uses the Housing.GetFieldPlot() method, which is player-specific and includes null safety. This affects portal usage, UGC map loading, and planner mode handling. Additionally, the default plot creation is skipped for the default home map, and the map loading query excludes the default home map when no owner is specified.

Changes

Files	Change Summary
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs	Updated Init to skip default plot creation for home map; modified UsePortal to use session.Housing.GetFieldPlot() for portal cube retrieval instead of .First().Value.
Maple2.Server.Game/PacketHandlers/LoadUgcMapHandler.cs	Replaced direct plot access with session.Housing.GetFieldPlot(), adding null check before proceeding.
Maple2.Server.Game/Session/GameSession.cs	Updated plot access in planner mode and return logic to use Housing.GetFieldPlot() with null safety.
Maple2.Database/Storage/Game/GameStorage.Map.cs	Modified LoadPlotsForMap query to exclude default home map when ownerId is less than zero.

Sequence Diagram(s)

sequenceDiagram
    participant Player
    participant GameSession
    participant Housing
    participant FieldManager

    Player->>GameSession: Use Portal / Enter Planner Mode / Load UGC Map
    GameSession->>Housing: GetFieldPlot()
    Housing-->>GameSession: Player-specific Plot (nullable)
    alt Plot exists
        GameSession->>FieldManager: Proceed with portal or planner logic
    else Plot is null
        GameSession-->>Player: Abort operation (early return)
    end

Loading

Suggested reviewers

• Zintixx

Poem

In fields of code where portals gleam,
A rabbit hops with housing dream—
No longer first, but player’s own,
The plots are fetched, the seeds are sown.
With null checks tight and logic neat,
This patch ensures no faulty feat!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff93327 and 8569476.

📒 Files selected for processing (1)

• Maple2.Database/Storage/Game/GameStorage.Map.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Maple2.Database/Storage/Game/GameStorage.Map.cs

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.