fix: prevent removal of items without expiry time in itemcollection sort

[AngeloTadeucci]

• Fix: Sorting items with expiration time get removed #544

Summary by CodeRabbit

• Bug Fixes
  • Enhanced item expiration handling to more accurately remove expired items from inventory.

[coderabbitai]

Walkthrough

This change updates the InventoryManager class by modifying the Sort method to remove expired items based on each item's IsExpired() method instead of comparing expiry times to the current timestamp.

Changes

File(s)	Change Summary
Maple2.Server.Game/Manager/Items/InventoryManager.cs	Changed expired item removal in Sort to use IsExpired() check instead of direct timestamp comparison.

Estimated code review effort

1 (~2 minutes)

Possibly related PRs

• Stack items with expiration dates #303: Both PRs modify expiry time-related logic in InventoryManager, though in different methods and contexts.

Suggested reviewers

• Zintixx

Poem

A rabbit hopped through code so neat,
Sorting items, quick on its feet.
Expiry checked with extra care,
Items gone when time's unfair.
With every hop, the logic's right—
Inventory shines, tidy and bright!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d7e49e and 7a18437.

📒 Files selected for processing (1)

• Maple2.Server.Game/Manager/Items/InventoryManager.cs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• Maple2.Server.Game/Manager/Items/InventoryManager.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build
• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

Maple2.Server.Game/Manager/Items/InventoryManager.cs (2)

498-501: Leverage the existing Item.IsExpired() helper instead of duplicating the check

IsExpired() is used throughout this class (e.g., in ConsumeItemComponents and Find).
Sticking to the helper keeps the semantics in one place and makes future behaviour changes (e.g., introducing a grace period) trivial.

-                IList<Item> toRemove = items.Where(item => item.ExpiryTime > 0 && item.ExpiryTime <= now).ToList();
+                IList<Item> toRemove = items.Where(item => item.IsExpired()).ToList();

No functional difference today, just maintainability/readability.

---

312-312: Nit: orphaned comment outside any case label hampers readability

This comment line now sits in the switch body but outside a case.
Although legal (comments are ignored by the compiler), it visually suggests a missing case 90000026: implementation.

Either re-indent it under a case (commented out) or move it above the closing brace to avoid confusion.

-            // case 90000026: // Unknown (Blank)
+            // case 90000026: // Unknown (Blank)

(or drop the line entirely if the placeholder is no longer useful).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13fb7d8 and 3d7e49e.

📒 Files selected for processing (1)

• Maple2.Server.Game/Manager/Items/InventoryManager.cs (2 hunks)