Skip to content

Respect the spawn area health override in the monster attribute system #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sven-n merged 1 commit into from
Sep 15, 2026
Merged

Respect the spawn area health override in the monster attribute system #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/GameLogic/Attributes/MonsterAttributeHolder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ public float GetValueOfAttribute(AttributeDefinition attributeDefinition)
return attribute.Value;
}

// A spawn area can override the maximum health of its npc (e.g. the blood castle gate
// and statue, or summoned monsters). AttackableNpcBase.Initialize starts them off with
// that health, so the maximum has to be reported accordingly. Otherwise every
// percentage-based readout divides the real health by the unrelated, usually much higher
// value of the monster definition.
if (attributeDefinition == Stats.MaximumHealth
&& this._monster.SpawnArea.MaximumHealthOverride is { } maximumHealthOverride)
{
return maximumHealthOverride;
}

if (this._statAttributes.TryGetValue(attributeDefinition, out float value))
{
return value;
Expand Down