Repository navigation
Enterprise tinybird selfhosted - #10
Merged
Merged
Conversation
Makisuo
added a commit
that referenced
this pull request
May 31, 2026
…67) Fixes 11 reported failure modes in the maple-dashboard-widgets MCP surface where dashboards looked correctly scoped but weren't, the verifier couldn't check the hardest widgets, and writes crashed on tag-less dashboards. whereClause (packages/query-engine query-builder): - Auto-route bare trace keys to attr.<key> instead of silently dropping them, so query.context/error.type/db.system filters actually apply. - Honor negation: !=, !contains, !exists now set `negated` instead of collapsing to the positive predicate (SQL layer already supported it). - add/update/replace widget tools reject the write (nothing saved) when the builder reports an unhonored clause, instead of persisting a mis-scoped chart. inspect_chart_data accuracy: - Evaluate formulas[] server-side (evaluator lifted to @maple/query-engine and re-exported from web) so formula/hit-rate widgets verify end-to-end. - reduceToValue falls back to the first numeric column like the renderer, so stat tiles no longer report a false reducedValue: null. - New EMPTY_GROUPING flag when a groupBy collapses to a single "all" series. - New METRIC_NOT_FOUND flag distinguishing a typo'd metric from an empty one. - SUSPICIOUS_GAP is now informational and no longer downgrades the verdict. - list_metrics no longer prints category totals next to a zero-match filter. Write path: - tags/description optionalKey crash hardened across all DashboardDocument / PortableDashboardDocument construction sites (conditional spread). - get_dashboard always emits a tags array so JSON round-trips through writes. - New replace_dashboard_widgets tool: atomic, validated whole-list rebuild. Docs: corrected SKILL.md + maple://instructions (groupBy attr. prefix, the full operator table incl. negation, legacy metric-fields) and documented the new behaviors. Deferred to follow-up PRs: #10 numeric-attribute aggregation (hot query path, needs live e2e), #12 query_engine.* metric ingestion (OTLP MeterProvider). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Makisuo
added a commit
that referenced
this pull request
May 31, 2026
…67) Fixes 11 reported failure modes in the maple-dashboard-widgets MCP surface where dashboards looked correctly scoped but weren't, the verifier couldn't check the hardest widgets, and writes crashed on tag-less dashboards. whereClause (packages/query-engine query-builder): - Auto-route bare trace keys to attr.<key> instead of silently dropping them, so query.context/error.type/db.system filters actually apply. - Honor negation: !=, !contains, !exists now set `negated` instead of collapsing to the positive predicate (SQL layer already supported it). - add/update/replace widget tools reject the write (nothing saved) when the builder reports an unhonored clause, instead of persisting a mis-scoped chart. inspect_chart_data accuracy: - Evaluate formulas[] server-side (evaluator lifted to @maple/query-engine and re-exported from web) so formula/hit-rate widgets verify end-to-end. - reduceToValue falls back to the first numeric column like the renderer, so stat tiles no longer report a false reducedValue: null. - New EMPTY_GROUPING flag when a groupBy collapses to a single "all" series. - New METRIC_NOT_FOUND flag distinguishing a typo'd metric from an empty one. - SUSPICIOUS_GAP is now informational and no longer downgrades the verdict. - list_metrics no longer prints category totals next to a zero-match filter. Write path: - tags/description optionalKey crash hardened across all DashboardDocument / PortableDashboardDocument construction sites (conditional spread). - get_dashboard always emits a tags array so JSON round-trips through writes. - New replace_dashboard_widgets tool: atomic, validated whole-list rebuild. Docs: corrected SKILL.md + maple://instructions (groupBy attr. prefix, the full operator table incl. negation, legacy metric-fields) and documented the new behaviors. Deferred to follow-up PRs: #10 numeric-attribute aggregation (hot query path, needs live e2e), #12 query_engine.* metric ingestion (OTLP MeterProvider). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Makisuo
added a commit
that referenced
this pull request
May 31, 2026
Fixes 11 reported failure modes in the maple-dashboard-widgets MCP surface where dashboards looked correctly scoped but weren't, the verifier couldn't check the hardest widgets, and writes crashed on tag-less dashboards. whereClause (packages/query-engine query-builder): - Auto-route bare trace keys to attr.<key> instead of silently dropping them, so query.context/error.type/db.system filters actually apply. - Honor negation: !=, !contains, !exists now set `negated` instead of collapsing to the positive predicate (SQL layer already supported it). - add/update/replace widget tools reject the write (nothing saved) when the builder reports an unhonored clause, instead of persisting a mis-scoped chart. inspect_chart_data accuracy: - Evaluate formulas[] server-side (evaluator lifted to @maple/query-engine and re-exported from web) so formula/hit-rate widgets verify end-to-end. - reduceToValue falls back to the first numeric column like the renderer, so stat tiles no longer report a false reducedValue: null. - New EMPTY_GROUPING flag when a groupBy collapses to a single "all" series. - New METRIC_NOT_FOUND flag distinguishing a typo'd metric from an empty one. - SUSPICIOUS_GAP is now informational and no longer downgrades the verdict. - list_metrics no longer prints category totals next to a zero-match filter. Write path: - tags/description optionalKey crash hardened across all DashboardDocument / PortableDashboardDocument construction sites (conditional spread). - get_dashboard always emits a tags array so JSON round-trips through writes. - New replace_dashboard_widgets tool: atomic, validated whole-list rebuild. Docs: corrected SKILL.md + maple://instructions (groupBy attr. prefix, the full operator table incl. negation, legacy metric-fields) and documented the new behaviors. Deferred to follow-up PRs: #10 numeric-attribute aggregation (hot query path, needs live e2e), #12 query_engine.* metric ingestion (OTLP MeterProvider). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.