Skip to content

feat(infra): add icons to the Add a source strip - #1379

Merged
Makisuo merged 3 commits into
mainfrom
feat/infra-add-source-icons
Oct 10, 2026
Merged

Makisuo merged 3 commits into
mainfrom
feat/infra-add-source-icons

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

The "Add a source" strip on the infrastructure overview was text only. This adds:

  • a terminal icon on Install a collector (it opens the install-command modal)
  • a trailing arrow on Connect a provider (it navigates to /integrations)
  • each source's logo inline in the "Not reporting yet" sentence, which otherwise stays plain text

SourceMark in infra-overview.tsx is now exported and takes an optional className so the route can reuse the source logos inline.

🤖 Generated with Claude Code

Install a collector gets a terminal icon, Connect a provider a trailing
arrow, and the missing sources render as logo chips instead of a comma list.
@Makisuo
Makisuo force-pushed the feat/infra-add-source-icons branch from 4e0f7ce to 0dec43e Compare October 10, 2026 22:16
@maple-review-bot

maple-review-bot Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Note

A newer push replaced 4e0f7ce before its review finished. The latest commit is reviewed in a new comment.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 39fa08c4-13de-4313-ab7e-c2ee2ef4a7d5

📥 Commits

Reviewing files that changed from the base of the PR and between d3d54b2 and 36f9c9f.


📒 Files selected for processing (2)
  • apps/web/src/components/infra/overview/infra-overview.tsx
  • apps/web/src/routes/infra/index.tsx

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maple-review-bot

maple-review-bot Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Note

A newer push replaced 0dec43e before its review finished. The latest commit is reviewed in a new comment.

@maple-review-bot

maple-review-bot Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge
Contained markup change: one new optional prop merged through cn and two icon imports, both verified to accept className.
quality 100/100 · no findings · tests not needed · risk low

Adds icons to the infrastructure "Add a source" strip: a terminal glyph on Install a collector, a trailing arrow on Connect a provider, and inline source logos on each not-reporting name. The icon tile the description mentions was dropped in the second commit. Safe to merge.

  • SourceMark takes a className merged with cn and is now exported
  • Missing sources render as nowrap name spans with inline source logos
  • Install a collector button swaps PlusIcon for SquareTerminalIcon
  • Connect a provider button gains a trailing ArrowRightIcon
What was checked
  • SourceMark's new className merges through cn (infra-overview.tsx:91), so existing callers keep the base classes
  • SquareTerminalIcon and ArrowRightIcon both apply className, so the button's [&_svg]:size-3.5 sizes them
  • missing.length > 0 still guards the strip, so the new map never renders an empty list

076ff98 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

Stacks the text above the buttons below a 42rem container, makes the buttons
full width on phones, and lets the source list wrap between items.
@Makisuo
Makisuo merged commit 239555d into main Oct 10, 2026
37 checks passed
@Makisuo
Makisuo deleted the feat/infra-add-source-icons branch October 10, 2026 22:23
@maple-review-bot

maple-review-bot Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge
quality 100/100 · no findings · tests not needed · risk low

Adds a terminal icon and a trailing arrow to the "Add a source" strip's buttons, inlines each source's SourceMark in the "Not reporting yet" sentence, and restacks that strip on narrow containers. Safe to merge.

  • SourceMark exported with an optional className, merged over its default ink
  • Source logos now render inline in the "Not reporting yet" sentence
  • Buttons get SquareTerminalIcon and ArrowRightIcon, swapping out PlusIcon
  • Strip stacks text over full-width buttons below a 42rem container

36f9c9f · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant