Repository navigation
refactor(web): simpler Google Cloud connection rows - #1504
Closed
JeremyFunk wants to merge 5 commits into
Closed
JeremyFunk wants to merge 5 commits into
JeremyFunk wants to merge 5 commits into
Conversation
A healthy connection is one row: its name, what it collects, and when logs and metrics last arrived. Anything else expands the card: one headline per thing to know or do, with its explanation and the card's one button, then Logs and Key metrics side by side with links to where the data shows up. - Configure moves into the row menu, beside View logs, View infrastructure and Disconnect. - The header drops the "Last log entry / Last metrics / Projects" facts row, which repeated the connections; the status line carries the project count. - Words in sans, ids and commands in mono. - /lab/gcp-connections shows each state over fixture connectors.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # apps/web/src/lab/registry.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1478.
The connection card read as a wall of mono text: the header facts repeated the row, two near-identical "about 10 minutes" notes, and Configure took space on every row.
/lab/gcp-connectionsrenders each state from fixture connectors.Design: Paper file "Maple — Google Cloud integration", page "GCP integration redesign", artboards D1–D5.
Checked:
/lab/gcp-connectionsin the browser (all six states and the row menu). Ran scoped vitest (lab registry, public routes, integrations: 110 tests passed) and oxlint on the changed files. No local typecheck; CI covers it.Need help on this PR? Tag
@codesmith-botwith what you need.