You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@andrerav@lofcz This will also resolve issue #723.
By calling the constructor with a default parameter.
Instead of creating a constructor without this parameter. As in the previous solution #761.
Which of the two solutions presented is better?
I think seems this solution is better. Especially if these created classes are used in other mappings. 🤔
Great @DocSvartz. Whenever you have PR's that you think is ready to be merged, could you please assign me as reviewer and I will review as soon as I can?
@andrerav This not ready for RecordType (
In terms of the fixes. It's more convenient for me to add them as one PR.
But then it will be more difficult to review.
Or I can enable it only for Classes.
And for records this will already be included as part of the fix MapTotarget behavior for RecordType (new PR)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#456 When explicitly set to ignore():
RequireDestinationMemberSource = true,#707 #723 RecordTypes and Generated Type to Interface received support Ignore() from Ctor parameters