Skip to content

Error message for MaterialDesignOutlinedTextBox should has same margin/padding as HelperText #2596

Closed

Description

@lszczygielek

Error message for MaterialDesignOutlinedTextBox should has same margin/padding as HelperText.

helper-text
validation-error

<TextBox Style="{StaticResource MaterialDesignOutlinedTextBox}"
		 materialDesign:HintAssist.Hint="Category name*"
		 materialDesign:HintAssist.HelperText="*Required"/>

Side note: I think that the issue is connected with PR #2217 that fixed the padding specification on Filled or Outlined TextBox style. Unfortunately it doesn't cover validation template.

Activity

  1. ElieTaillard commented on Apr 21, 2022

    @ElieTaillard
    Collaborator

    The HelperText issue has been fixed #2648

    Now we need to solve the issue with the validation style.

    • HelperText
    • Validation.HasError
  2. ElieTaillard commented on Jul 21, 2022

    @ElieTaillard
    Collaborator

    The task is available if someone wants to work on it

  3. added this to the 4.6.0 milestone on Aug 18, 2022
  4. nicolaihenriksen commented on Aug 20, 2022

    @nicolaihenriksen
    Contributor

    @Xaalek I believe the linked PR should solve the validation error margin issue.

  5. moved this from Todo to In Progress in MDIX - Issues Managementon Aug 20, 2022
  6. ElieTaillard commented on Aug 21, 2022

    @ElieTaillard
    Collaborator

    @nicolaihenriksen From what I remember, the styling was incorrect for the outlined and filled fields. This was for the TextBox, Password, ComboBox, DatePicker and RickTextBox controls.
    We should check if all the controls are in accordance with the specs https://material.io/components/text-fields

  7. nicolaihenriksen commented on Aug 22, 2022

    @nicolaihenriksen
    Contributor

    @Xaalek Indeed you are correct. I will push more commits to the PR fixing the remaining ones...

  8. Repository owner moved this from In Progress to Done in MDIX - Issues Managementon Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions