Skip to content

Floating hint textblock cut off for right-aligned fields #3055

Closed

Description

@yosefmah

Bug explanation

Bug possibly introduced with #3041

When setting a HorizontalContentAlignment to right, the hint is cut off as it matches the width of the entered text.

image

When entering longer text, the hint expands to show the full text but given the width of the Textbox it should always be visible.

image

Version

4.7.1

Activity

  1. nicolaihenriksen commented on Jan 20, 2023

    @nicolaihenriksen
    Contributor

    @yosefmah You are absolutely correct that #3041 has introduced a regression. This is how it was before (which IMO is actually also misaligned, but that is a different issue):
    BeforeFix

    And this it how it works after:
    AfterFix

    I'll look into fixing it.

  2. added this to the 4.8.0 milestone on Jan 23, 2023
  3. yosefmah commented on Jan 23, 2023

    @yosefmah
    ContributorAuthor

    Thanks for looking into this @nicolaihenriksen

    I actually think the problem is broader than I originally stated - it seems to impact HorizontalContentAlignment="Left" and HorizontalContentAlignment="Center" as well. Only HorizontalContentAlignment="Stretch" seems to not be affected.

  4. nicolaihenriksen commented on Jan 23, 2023

    @nicolaihenriksen
    Contributor

    I actually think the problem is broader than I originally stated

    I agree. And as you can see in the linked draft PR, I actually think we should revert the changes until we have a proper fix. I still believe the old implementation has issues, but not "as severe" as the new implementation. I'm currently waiting for some feedback from @Keboo about what to do about this (in the linked PR). Maybe he has a trick up his sleeve to solve it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions