You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Floating hint textblock cut off for right-aligned fields #3055
@yosefmah You are absolutely correct that #3041 has introduced a regression. This is how it was before (which IMO is actually also misaligned, but that is a different issue):
I actually think the problem is broader than I originally stated - it seems to impact HorizontalContentAlignment="Left" and HorizontalContentAlignment="Center" as well. Only HorizontalContentAlignment="Stretch" seems to not be affected.
I actually think the problem is broader than I originally stated
I agree. And as you can see in the linked draft PR, I actually think we should revert the changes until we have a proper fix. I still believe the old implementation has issues, but not "as severe" as the new implementation. I'm currently waiting for some feedback from @Keboo about what to do about this (in the linked PR). Maybe he has a trick up his sleeve to solve it...
Activity
nicolaihenriksen commentedon Jan 20, 2023
@yosefmah You are absolutely correct that #3041 has introduced a regression. This is how it was before (which IMO is actually also misaligned, but that is a different issue):

And this it how it works after:

I'll look into fixing it.
yosefmah commentedon Jan 23, 2023
Thanks for looking into this @nicolaihenriksen
I actually think the problem is broader than I originally stated - it seems to impact
HorizontalContentAlignment="Left"andHorizontalContentAlignment="Center"as well. OnlyHorizontalContentAlignment="Stretch"seems to not be affected.nicolaihenriksen commentedon Jan 23, 2023
I agree. And as you can see in the linked draft PR, I actually think we should revert the changes until we have a proper fix. I still believe the old implementation has issues, but not "as severe" as the new implementation. I'm currently waiting for some feedback from @Keboo about what to do about this (in the linked PR). Maybe he has a trick up his sleeve to solve it...