Add the desktop-processing protocol tasks - #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the desktop-processing protocol into the python library. The V3Schema pin predated the protocol entirely, and even at schema HEAD the
Threeservice was missing the rpc entries (fixed in Matter-and-Form/V3Schema#50), so the generatedScannerclass never gained the new methods.Changes:
scanner.py: 12 new methods (get_protocol_info,set_processing_devices,connect_scanner,disconnect_scanner,get_scanner_status,list_scanner_projects,push_project,pull_project,remove_scanner_projects,download_scanner_project,storage_info,discover_scanners) plus the five new descriptors.scanner.pyi(a stale stub file hides the new methods from type checkers and IDE completion).Verified: flake8 clean,
python -m buildsucceeds, and the built library was smoke-tested live against a desktop engine (get_scanner_status,storage_info,discover_scannersand existing tasks round-trip correctly). Wire compatibility is purely additive: no existing task or descriptor changed shape, so this is safe against both release (11.13.0) and RC firmware.