fix: remove confidence from rawWriteInterpretationSchema to fix OpenAI 400#80
Merged
Conversation
…I structured output 400
z.record() produces additionalProperties in JSON Schema, which OpenAI's structured
outputs rejects — it requires every key in required to appear in properties.
Confidence was never populated by the LLM in practice; unresolvedFields handles
ambiguity instead. Remove confidence from the raw schema, default it to {} in
the normalizer, and default the ?? lookup to 1 (fully trusted) so existing
commit-policy thresholds are unaffected.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confidencefield fromrawWriteInterpretationSchema—z.record()generatesadditionalPropertiesin JSON Schema which OpenAI structured outputs rejects with a 400 ("Extra required key 'confidence' supplied")confidenceto{}innormalizeRawWriteInterpretationso theWriteInterpretationtype is still satisfied?? 0to?? 1inwrite-commit.tsso fields with no explicit confidence are treated as fully trusted (preserving existing behavior — the LLM was never populating this field)Test Plan
pnpm --filter @atlas/core typecheck— passespnpm --filter @atlas/core test— 119 tests passatlas_write_interpretation_output400 no longer occurs in production