healthcheck and depends_on service_healthy are silently ignored #117

Activity

1. ryan106 commented on Jul 2, 2026

   

   ryan106

   on Jul 2, 2026

   Contributor

   More actions

   This also looks fixed (likely by #119, same as #115/#52) — depends_on: condition: is fully implemented in ComposeUp.swift's waitForDependencyConditions, not silently ignored:

   case ServiceDependency.serviceStarted:
       guard serviceStartStates[dependencyName] != nil else {
           throw ComposeError.dependencyNotStarted(serviceName, dependencyName)
       }
   case ServiceDependency.serviceHealthy:
       guard serviceHealth[dependencyName] == true else {
           throw ComposeError.dependencyNotHealthy(serviceName, dependencyName)
       }
   case ServiceDependency.serviceCompletedSuccessfully:
       guard serviceStartStates[dependencyName] == .completed else {
           throw ComposeError.dependencyNotCompleted(serviceName, dependencyName)
       }
   default:
       throw ComposeError.unsupportedDependencyCondition(serviceName, dependencyName, dependency.effectiveCondition)

   healthcheck: itself runs real polling via waitUntilServiceIsHealthy (container exec + configured retries/interval/start_period), and any condition this doesn't recognize throws a clear unsupportedDependencyCondition error rather than being dropped — matching the "Definition of done" from #118 (clear diagnostics instead of silent behavior differences). Looks resolved.
2. thromel commented on Jul 2, 2026

   

   thromel

   on Jul 2, 2026

   ContributorAuthor

   More actions

   Closing as completed by #119. Current main implements depends_on condition handling for service_started, service_healthy, and service_completed_successfully, with healthcheck polling and explicit errors for unsupported conditions.
3. thromel

   closed this as completedon Jul 2, 2026