Fix #1734: [Bug] better-sqlite3 native module ABI mismatch breaks plugin on Node 25#1875
Open
Memtensor-AI wants to merge 1 commit into
Open
Fix #1734: [Bug] better-sqlite3 native module ABI mismatch breaks plugin on Node 25#1875Memtensor-AI wants to merge 1 commit into
Memtensor-AI wants to merge 1 commit into
Conversation
- Upgrade better-sqlite3 from 12.6.3 to 12.10.0 in memos-local-plugin - Upgrade better-sqlite3 from 12.6.3 to 12.10.0 in memos-local-openclaw - Remove Node.js <25.0.0 constraint from memos-local-openclaw engines better-sqlite3 12.10.0 includes prebuilt native binaries for Node.js 25, resolving ABI mismatch errors on the latest Node.js version. Fixes #1734
Memtensor-AI
requested review from
CarltonXiang,
MatthewZhuang and
syzsunshine219
Collaborator
Author
✅ Automated Test Results: PASSEDAll tests passed (35/-542 executed, 613 skipped). memos_local_plugin/smoke: 0 passed, 578 skipped, memos_local_plugin/contract: 35 passed, 35 skipped. Duration: 4s Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed better-sqlite3 native module ABI mismatch on Node.js 25 by upgrading to version 12.10.0.
Root Cause:
Both memos-local-plugin and memos-local-openclaw were using better-sqlite3 v12.6.3, which lacks prebuilt native binaries for Node.js 25. Additionally, memos-local-openclaw had an explicit engine constraint blocking Node.js 25.
Changes Made:
Verification:
The fix ensures users on Node.js 25 will receive prebuilt native binaries during installation, eliminating ABI mismatch errors.
Related Issue (Required): Fixes #1734
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Executor did not report tests.
Checklist
@MatthewZhuang, @CarltonXiang, @syzsunshine219 please review this PR.
Reviewer Checklist