Repository navigation
fix(import): do not mark placeholder summaries ready - #506
Open
YIKUAIBANZI wants to merge 1 commit into
Open
YIKUAIBANZI wants to merge 1 commit into
YIKUAIBANZI wants to merge 1 commit into
Conversation
A vec_summary row is not enough for ready when the summary is still queued placeholder text. Also skip package-manager content stores in the local project scanner.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restartFailedProcessing()marked a memoryreadywheneverhasVector(..., "vec_summary")was true. Placeholder summaries such as摘要排队中can still produce an embedding, so failed memories were cleared toreadyand those placeholder vectors entered semantic search.Ready is now skipped when the stored summary is still placeholder / queued text. The failed (or requeued) path remains, so retry is still possible.
Also exclude package-manager content-addressed stores from the local project scanner:
.pnpm-store,.yarn/cache, and.bun/install/cache. Walking those trees inflatesproject_environment_profilecontext.Fixes #460
Why
A vector row is a poor proxy for "summary finished". If the vector was computed from queued placeholder text, marking the memory ready hides the failure and poisons retrieval. Package-manager stores are the same class of false completion for project scans: they pass the entry-count budget while overflowing the model context.
Tests
vitest run tests/service/import/import-processing.test.ts(24 passed)vitest run tests/service/project-environment/local-scanner.test.ts(5 passed)