Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readJsonlObjectschecks cancellation only when starting a new file chunk. If a caller aborts after reading the first of two JSONL rows in the same chunk, the next iteration still returns the buffered second row. A pre-aborted empty-file read also completes without anAbortError.Check the existing abort signal before opening the stream, before processing each buffered record, and before parsing the final unterminated record. Preserve the existing
AbortErrorand stream-cleanup behavior. This affects the shared reader used by Agent history import; it does not change persistence semantics or claim that higher-level scan cancellation writes extra memories.Three real-file regressions cover buffered cancellation with/without a final newline and a pre-aborted empty file. Before the fix: 61 passed, 3 failed. After the fix:
npm test -w @memmy/agent-source-core: 64 passed.npm run build -w @memmy/agent-source-core: passed.npm run typecheck -w @memmy/agent-source-core: passed.AgentSourceCore/node_modules/.bin/tsc -p AgentSourceCore/src/tests/tsconfig.json --noEmit: passed.git diff --check: passed.Validated on Windows with Node 24. Backend/Memory consumer integration suites and desktop/Electron builds were not run. No dependency or lockfile changes.
Implemented and tested with AI assistance.