Skip to content

devDeps: bump devDependencies - #38

Merged
legobeat merged 11 commits into
MetaMask:mainfrom
legobeat:devDeps-bumps-202307
Jul 18, 2023
Merged

legobeat merged 11 commits into
MetaMask:mainfrom
legobeat:devDeps-bumps-202307

Conversation

@legobeat

@legobeat legobeat commented Jul 7, 2023 •

Copy link
Copy Markdown
Contributor
  • update @metamask/eslint-config* and peerDependencies to latest
    • apply lint:fix and update eslintrc
  • bump eslint
  • bump jest
  • set @types/node to latest 16

Contains/supersedes:

@legobeat legobeat mentioned this pull request Jul 12, 2023
@legobeat
legobeat force-pushed the devDeps-bumps-202307 branch from 102f494 to 6f92049 Compare July 12, 2023 20:01
@legobeat legobeat changed the title devDeps: minor bumps; dedupe devDeps: bump devDependencies Jul 14, 2023
@legobeat
legobeat force-pushed the devDeps-bumps-202307 branch from 6f92049 to 2b79b15 Compare July 14, 2023 01:50
@legobeat
legobeat marked this pull request as ready for review July 14, 2023 01:53
@legobeat
legobeat requested a review from a team as a code owner July 14, 2023 01:53
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@socket-security

socket-security Bot commented Jul 14, 2023 •

Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-n 15.7.0 filesystem +4 883 kB weiran.zsd
eslint-plugin-import 2.26.0 network +3 1.13 MB ljharb
@metamask/eslint-config-typescript 11.1.0...12.1.0 None +1/-1 37 kB metamaskbot
@metamask/eslint-config-nodejs 11.1.0...12.1.0 None +6/-3 996 kB metamaskbot

🚮 Removed packages: @metamask/eslint-config@11.1.0, @types/node@17.0.45, eslint-plugin-node@11.1.0, jest@28.1.3, ts-jest@28.0.8

@socket-security

socket-security Bot commented Jul 14, 2023 •

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: builtins@5.0.1, debug@2.6.9, eslint-plugin-n@15.7.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat

Copy link
Copy Markdown
Contributor Author
@SocketSecurity ignore builtins@5.0.1
@SocketSecurity ignore eslint-plugin-n@15.7.0

mcmire
mcmire previously approved these changes Jul 17, 2023

@mcmire mcmire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread package.json Resolved
@legobeat
legobeat force-pushed the devDeps-bumps-202307 branch from 60fb8c3 to 4d9341c Compare July 17, 2023 18:08
@legobeat
legobeat requested review from a team and mcmire July 17, 2023 18:29
@legobeat

Copy link
Copy Markdown
Contributor Author
@SocketSecurity ignore debug@2.6.9

@legobeat
legobeat merged commit b667e75 into MetaMask:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants