Skip to content

TokensController & CollectiblesController #516

Closed

Description

@adonesky1

This work was conceived to help land the TokenRatesController in the extension. As it stands the TokenRatesController depends on the AssetsController, which is also not yet integrated into the Extension. Rather than adapting the AssetsController to make collectibles optional, It that the AssetsController can and should be broken out into a TokensController and a CollectiblesController. The primary reason for this being that Collectibles and Tokens live in separate pieces of the controllers state state and lumping them together makes the controller less modular, harder to reason about and maintain.

  • Split out AssetsController into new separate TokensController and CollectiblesController
  • Convert both to V2

Activity

  1. self-assigned this
    on Jul 8, 2021
  2. desi commented on Apr 22, 2024

    @desi
    Contributor

    These controllers were split and we have another ticket to handle the upgrade to BaseController V2. Closing this ticket. Please reopen if concerns.

  3. added a commit that references this issue on Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions