Skip to content

Replace eth-query with ethjs-query? #731

Closed as not planned
Closed as not planned

Description

@mcmire

These packages sound the same but they are different.

Related issue: #108

Activity

  1. changed the title [-]Replace eth-query with ethjs-query[/-] [+]Replace eth-query with ethjs-query?[/+] on Mar 18, 2022
  2. legobeat commented on Dec 8, 2022

    @legobeat
    Contributor

    I guess this is not relevant anymore? #852

  3. mcmire commented on Dec 8, 2022

    @mcmire
    CollaboratorAuthor

    I agree that this issue and #852 are mutually exclusive. I made them both because I wasn't sure what our long-term strategy was at the time.

    Now that some time has passed, it seems like this issue is definitely relevant: considering that you've recently forked all of the ethjs-* packages, it would seem that we at least want to keep using those packages, which would imply that we don't want to use the eth-* packages.

    As for the issue you mentioned, however: is it irrelevant? Perhaps not everyone would agree with the conclusion I gave — there are arguments to be made for not using Ethers for everything — but I think everyone has admitted, or at least hinted, that we ought to use newer libraries, and it sounds like you agree. But perhaps that view has changed?

  4. MajorLift commented on Feb 8, 2024

    @MajorLift
    Contributor
  5. mcmire commented on Feb 8, 2024

    @mcmire
    CollaboratorAuthor

    Ah, yes. The new technical proposals answer this question by suggesting that we merge these two libraries together. Closing this since we can discuss this further within that proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions