You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree that this issue and #852 are mutually exclusive. I made them both because I wasn't sure what our long-term strategy was at the time.
Now that some time has passed, it seems like this issue is definitely relevant: considering that you've recently forked all of the ethjs-* packages, it would seem that we at least want to keep using those packages, which would imply that we don't want to use the eth-* packages.
As for the issue you mentioned, however: is it irrelevant? Perhaps not everyone would agree with the conclusion I gave — there are arguments to be made for not using Ethers for everything — but I think everyone has admitted, or at least hinted, that we ought to use newer libraries, and it sounds like you agree. But perhaps that view has changed?
Ah, yes. The new technical proposals answer this question by suggesting that we merge these two libraries together. Closing this since we can discuss this further within that proposal.
Activity
[-]Replace eth-query with ethjs-query[/-][+]Replace eth-query with ethjs-query?[/+]legobeat commentedon Dec 8, 2022
I guess this is not relevant anymore? #852
mcmire commentedon Dec 8, 2022
I agree that this issue and #852 are mutually exclusive. I made them both because I wasn't sure what our long-term strategy was at the time.
Now that some time has passed, it seems like this issue is definitely relevant: considering that you've recently forked all of the
ethjs-*packages, it would seem that we at least want to keep using those packages, which would imply that we don't want to use theeth-*packages.As for the issue you mentioned, however: is it irrelevant? Perhaps not everyone would agree with the conclusion I gave — there are arguments to be made for not using Ethers for everything — but I think everyone has admitted, or at least hinted, that we ought to use newer libraries, and it sounds like you agree. But perhaps that view has changed?
MajorLift commentedon Feb 8, 2024
Looks like this could be closed by https://app.zenhub.com/workspaces/shared-libraries-621e46b4d7103800171d1b02/issues/zh/244?
mcmire commentedon Feb 8, 2024
Ah, yes. The new technical proposals answer this question by suggesting that we merge these two libraries together. Closing this since we can discuss this further within that proposal.