Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ Environment prerequisites (Node LTS + Yarn 4 via Corepack + `yarn install`) are

Standard lint/test/build commands are documented above and in `docs/processes/`. Non-obvious caveats for this environment:

- `yarn build` (whole monorepo, via `ts-bridge`) takes ~100s. `yarn lint:eslint` takes ~3–4 minutes.
- `yarn build` (whole monorepo, via `tsc --build`) takes ~100s. `yarn lint:eslint` takes ~3–4 minutes.
- `yarn lint:eslint` runs `build:only-clean` first, which **deletes all `packages/*/dist`**. Run `yarn build` again afterward if you need the built artifacts (tests don't need `dist`; they run TS/Babel directly).
- The full `yarn lint` does much more than ESLint (constraints, `knip` dependency checks, changelog/teams/tsconfig/codeowners checks); prefer `yarn lint:eslint` for a quick code-quality pass.
- Per-package tests are fast: `yarn workspace <package-name> run test`. `yarn test` across all packages is heavy.
Expand Down
5 changes: 3 additions & 2 deletions packages/perps-controller/src/PerpsController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2367,8 +2367,9 @@ export class PerpsController extends BaseController<
// is only used when explicitly enabled and selected.
const isLighterEnabled = this.#isLighterProviderEnabled();
if (isLighterEnabled) {
// NOTE: Keep the path in a variable so ts-bridge does not rewrite the
// import argument and strip the webpackIgnore magic comment in core dist.
// NOTE: Keep the path in a variable so bundlers that ignore the
// webpackIgnore magic comment (e.g. Metro) cannot statically resolve the
// import and pull the Lighter provider into the client bundle.
const lighterModulePath = './providers/LighterProvider';
this.#lighterRegistrationPromise = import(
/* webpackIgnore: true */ lighterModulePath
Expand Down
3 changes: 1 addition & 2 deletions packages/snap-account-service/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import { AccountId } from '@metamask/keyring-utils';
* `multichain-account-service` legitimately depends on `snap-account-service`
* (for `:ensureReady`), and `account-tree-controller` legitimately depends on
* `multichain-account-service`. Importing `AccountTreeController` types here
* would close the cycle and crash `ts-bridge` with a stack overflow during
* project-reference builds.
* would close the cycle and break project-reference builds (`tsc --build`).
*
* Keep these signatures in sync with `@metamask/account-tree-controller`.
*/
Expand Down
Loading