Repository navigation
Release 1340.0.0 - #10864
Merged
Merged
Release 1340.0.0#10864
Conversation
FrederikBolding
marked this pull request as ready for review
October 16, 2026 11:48
FrederikBolding
temporarily deployed
to
default-branch
October 16, 2026 11:48 — with
GitHub Actions
Inactive
FrederikBolding
temporarily deployed
to
default-branch
October 16, 2026 11:49 — with
GitHub Actions
Inactive
Contributor
|
✅ Changelogs updated and pushed. |
cryptodev-2s
previously approved these changes
Oct 16, 2026
FrederikBolding
force-pushed
the
release/1340.0.0
branch
from
October 16, 2026 12:10
3e5f68b to
a7c8afe
Compare
cryptodev-2s
approved these changes
Oct 16, 2026
Merged
1 of 4 tasks
gaohan1994
pushed a commit
to gaohan1994/core
that referenced
this pull request
Oct 27, 2026
## Explanation Major release of `@metamask/wallet` (`19.1.0` → `20.0.0`). - **Breaking:** Add `GeolocationController` and `GeolocationApiService` to the default initialization configurations. Optional `instanceOptions.geolocationApiService` accepts `env`, `fetch`, `ttlMs`, and `policyOptions` (defaults to production and `globalThis.fetch`). Hosts that already register these on the wallet root messenger must remove them before upgrading, or messenger registration will collide. Hosts no longer need to register `GeolocationController` when `AnalyticsController` `isGeolocationEnabled` is `true`. ([MetaMask#11058](MetaMask#11058)) - Add `@metamask/geolocation-controller` as a dependency. ([MetaMask#11058](MetaMask#11058)) Minor release of `@metamask/analytics-controller` (`4.0.0` → `4.1.0`). - Add support for Node.js 26. ([MetaMask#10981](MetaMask#10981)) - Accept partial initial `state` as long as `analyticsId` is provided. ([MetaMask#10901](MetaMask#10901)) - Bump `@metamask/base-controller` from `^10.0.0` to `^10.1.0`. ([MetaMask#10864](MetaMask#10864)) Dependent packages (`@metamask/marketing-consent-controller`, `@metamask/network-controller`, `@metamask/notification-services-controller`, `@metamask/seedless-onboarding-controller`, `@metamask/wallet`) now depend on `@metamask/analytics-controller` `^4.1.0`. ## References - [MetaMask#11058](MetaMask#11058) - [MetaMask#10981](MetaMask#10981) - [MetaMask#10901](MetaMask#10901) - [MetaMask#10864](MetaMask#10864) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Wallet 20.0.0 carries a documented breaking change to default controller registration (geolocation), so consumers upgrading from this release can hit messenger collisions or required migration steps even though this PR only versions and documents prior work. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 16059ef. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Release candidate for 1340.0.0.
Note
Medium Risk
Wide dependency propagation plus
@metamask/wallet18.0.0 breaking initialization changes affect every wallet consumer; controller bumps are semver-minor but touch core infrastructure packages.Overview
Prepares monorepo release 1340.0.0 by cutting
@metamask/base-controller@10.1.0and@metamask/network-controller@37.1.0, then aligning dependents on^10.1.0/^37.1.0across controller packages (changelogs andpackage.jsononly—no application logic in this diff).base-controller10.1.0 documentsvalidateControllerStateand adds@metamask/superstruct.network-controller37.1.0 documents a staticstructfor controller state. Both versions are wired through the tree via #10864.Also ships
@metamask/wallet@18.0.0(major) with breaking default initialization: requiredreferenceon stateful instances, and default wiring for Permission, SubjectMetadata, SelectedNetwork (domainProxyMap), Client, and Logging controllers.@metamask/wallet-clibumps@metamask/walletto^18.0.0andbase-controllerto^10.1.0. Root monorepo version moves 1339.0.0 → 1340.0.0.Reviewed by Cursor Bugbot for commit a7c8afe. Bugbot is set up for automated code reviews on this repo. Configure here.