Repository navigation
docs(perps-controller): client timings come from one overridable config - #11603
Merged
Merged
Conversation
abretonc7s
enabled auto-merge
November 18, 2026 01:20
abretonc7s
temporarily deployed
to
default-branch
November 18, 2026 01:20 — with
GitHub Actions
Inactive
Contributor
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owners. @MetaMask/perps (1 file)
|
geositta
approved these changes
Nov 18, 2026
abretonc7s
added a commit
to MetaMask/skills
that referenced
this pull request
Nov 18, 2026
) Regenerates perps-review-pr from MetaMask/experimental-metamask-recipe-perps#78. The inline-timeout rule now allows a connection-timing override in the client's one connection config (default `PERPS_CONSTANTS`), matching the clarified client contract in MetaMask/core#11603. Literals elsewhere are still a finding. `--check` passes. Skill-only change; no CHANGELOG entry.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Clarifies the timing line of the client contract (TAT-4656). It required clients to use the
PERPS_CONSTANTStimings "instead of local values", which reads as "never configurable". The intent is one source per client: a connection config that defaults toPERPS_CONSTANTS, where any override lives, with no scattered literals.Also notes that the controller itself never reads these three timings; each client's connection owner does. A controller-level option is tracked with the shared stream manager spike (TAT-4660), since it is only useful once Core owns the connection lifecycle.
Docs only, no code change.
References
Checklist
Note
Low Risk
Documentation-only clarification of an existing client contract; no code or connection logic changes.
Overview
Updates the perps-controller architecture doc so the TAT-4656 client contract no longer reads as “always use
PERPS_CONSTANTS, never override.”The Connection section now states that
PERPS_CONSTANTSholds default connection timings and that the controller does not consumeConnectionGracePeriodMs,ConnectionAttemptTimeoutMs, orConnectRetryDelayMs—each client’s connection owner does.The What a client must do bullet is reframed: clients should read timings from one per-client connection config that defaults to those
PERPS_CONSTANTSvalues, with any overrides living in that config instead of scattered local literals.Docs only; no runtime behavior change.
Reviewed by Cursor Bugbot for commit b529522. Bugbot is set up for automated code reviews on this repo. Configure here.