Repository navigation
Fix package name in README.md - #237
Merged
Merged
Conversation
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
…ain + Integrate PollingController Mixin (MetaMask#237) * Parameterize SmartTransactionsController state by ChainId for MultiChain + Integrate PollingController Mixin (MetaMask#210)
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
This is the release candidate for version 11.2.0. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 4, 2026
## Explanation
### Summary
Enable Arc (`0x13b2`) in the phishing-controller token-scan allowlist so
`bulkScanTokens` forwards Arc tokens to the Security Alerts API.
### Problem
Core already maps `0x13b2` to `arc` and enables Arc address scanning,
but `arc` is missing from `TOKEN_SCAN_SUPPORTED_CHAINS`. As a result,
`bulkScanTokens` treats Arc as unsupported, returns `{}`, and never
calls `/token/scan-bulk`.
This gap came from the order in which support landed:
- In June, [MetaMask#9248](MetaMask#9248) proposed
the Arc chain mapping and explicitly noted that it must not merge before
the Security Alerts API supported Arc token scans. It was closed after
[MetaMask#9506](MetaMask#9506) included that
mapping.
- In July, MetaMask#9506 introduced separate endpoint allowlists. Arc was
enabled for address scanning, while token scanning remained disabled
because the token endpoint did not yet support it.
- In October,
[PSAFE-715](https://consensyssoftware.atlassian.net/browse/PSAFE-715)
tracked the missing backend support after Blockaid-flagged fake Arc
tokens appeared in wallet token surfaces. [Security Alerts API
MetaMask#237](consensys-vertical-apps/va-mmcx-security-alerts-api#237)
added Arc token lookup, webhook, and backfill support.
- The API changes were [deployed and backfilled in production on October
16](https://consensys.slack.com/archives/C03MLR70YSK/p1791876650701109),
but the phishing-controller token allowlist was not updated.
Phishing-controller consumers therefore still skip Arc token scans
locally.
### Solution
- Add `arc` to `TOKEN_SCAN_SUPPORTED_CHAINS`.
- Add a regression test proving that `bulkScanTokens` resolves `0x13b2`
to `arc` and sends the request to `/token/scan-bulk`.
- Leave the address-scan and approval allowlists unchanged.
### Risk
This begins token-scan requests for Arc, which is the intended behavior
now that the production API accepts Arc and its token results have been
backfilled. Existing token-scan error handling remains unchanged and
fails open by returning an empty result.
## References
- Related to
[PSAFE-715](https://consensyssoftware.atlassian.net/browse/PSAFE-715)
- Follow-up to [MetaMask#9248](MetaMask#9248) and
[MetaMask#9506](MetaMask#9506)
- Backend support:
[consensys-vertical-apps/va-mmcx-security-alerts-api#237](consensys-vertical-apps/va-mmcx-security-alerts-api#237)
- Rollout context: [Arc token-security incident
thread](https://consensys.slack.com/archives/C03MLR70YSK/p1791876650701109)
## Checklist
- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
[PSAFE-715]:
https://consensyssoftware.atlassian.net/browse/PSAFE-715?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[PSAFE-715]:
https://consensyssoftware.atlassian.net/browse/PSAFE-715?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Turns on live token-security lookups for Arc; behavior matches other
chains and still fails open on API errors, but wallet token warnings now
depend on this path.
>
> **Overview**
> Adds **`arc`** to **`TOKEN_SCAN_SUPPORTED_CHAINS`**, so
**`bulkScanTokens`** for Arc (`0x13b2`) no longer bails out with `{}`
and instead posts to the Security Alerts **`/token/scan-bulk`** endpoint
(chain name `arc`).
>
> A regression test locks in that mapping and API payload, and the
package changelog notes the enablement now that the backend supports Arc
token verdicts.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ad37e86. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 7, 2026
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the package name throughout the README file, where it was sometimes referred to as singular "controller" instead of plural "controllers".