Skip to content

Add prepublishOnly build script - #260

Merged
whymarrh merged 1 commit into
MetaMask:developfrom
whymarrh:prepublishOnly
Aug 18, 2020
Merged

whymarrh merged 1 commit into
MetaMask:developfrom
whymarrh:prepublishOnly

Conversation

@whymarrh

Copy link
Copy Markdown
Contributor

This PR adds a prepublishOnly script entry to run the build process before publishing.

@whymarrh
whymarrh requested a review from a team as a code owner August 18, 2020 22:16
@whymarrh

Copy link
Copy Markdown
Contributor Author

Yes, v2.0.4 is incorrect because of this.

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh
whymarrh merged commit cbd16db into MetaMask:develop Aug 18, 2020
@whymarrh
whymarrh deleted the prepublishOnly branch August 18, 2020 22:25
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Sep 13, 2026
This is the release candidate for version 11.5.0.

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
…pgrading `ethereumjs-util` to latest (now called `@ethereumjs/util`) (MetaMask#260)

* upgrade ethereumjs-util to latest (@ethereumjs/util) and adapt accordingly

* fix types

* wip

* fix something

* swap out TextEncoder for Buffer.from

* fix number hashing

* fix more tests

* add comments

* all tests passing

* cutting out ethereumjs-abi

* add jsdocs

* fully remove old secp256k1 from dependency tree via ethereum-cryptography 0.1.3"

* progress?

* idk

* tests passing

* move ethereumjs-abi methods to their own file

* switch out toBuffers for typed specific buffer converts

* add tests for ethereumjs-abi-util functions

* lower test threshhold

* lint

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants