Skip to content

Transaction to smart contract - #76

Merged
estebanmino merged 7 commits into
masterfrom
audit/is-smart-contract
Mar 27, 2019
Merged

estebanmino merged 7 commits into
masterfrom
audit/is-smart-contract

Conversation

@estebanmino

Copy link
Copy Markdown
Contributor

This PR adds toSmartContract attribute to TransactionMeta object, it shows whether the transaction was sent to a smart contract or not, request that is being done only once when the tx is fetched.
This avoids requesting this information (hitting infura) each time we render a transaction or having the audit issue caching this information.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #76   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1221   1257   +36     
  Branches      141    156   +15     
=====================================
+ Hits         1221   1257   +36
Impacted Files Coverage Δ
src/TransactionController.ts 100% <100%> (ø) ⬆️
src/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43adebd...31c547c. Read the comment docs.

@codecov-io

codecov-io commented Mar 26, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #76   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1221   1257   +36     
  Branches      141    156   +15     
=====================================
+ Hits         1221   1257   +36
Impacted Files Coverage Δ
src/TransactionController.ts 100% <100%> (ø) ⬆️
src/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43adebd...ad24490. Read the comment docs.

Comment thread src/TransactionController.ts Outdated
* @property rawTransaction - Hex representation of the underlying transaction
* @property status - String status of this transaction
* @property time - Timestamp associated with this transaction
* @property toSmartContract - Whether transaction receipt is a smart contract

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipient ?

@brunobar79 brunobar79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estebanmino
estebanmino merged commit ccf2bef into master Mar 27, 2019
@bitpshr
bitpshr deleted the audit/is-smart-contract branch March 27, 2019 22:12
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
* 6.1.0

* Update changelog
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
* 2.1.0

* Update CHANGELOG.md

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
* Export Buffer from buffer package explicitly

* Fix export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants