Skip to content

Feature: implement method registry - #82

Merged
estebanmino merged 10 commits into
masterfrom
feature/method-registry
Apr 2, 2019
Merged

estebanmino merged 10 commits into
masterfrom
feature/method-registry

Conversation

@estebanmino

@estebanmino estebanmino commented Apr 1, 2019 •

Copy link
Copy Markdown
Contributor

This PR adds eth-method-registry to maintain transaction four byte method signatures, using handleMethodData, a method that can be used from mobile or the extension without interfering how TransactionController currently works.
This method receives a new four byte method signature. If that signature isn't known, is going to save it in state and return it. Next time is needed query the contract won't be necessary, having only one request per signature sent to the on-chain contract.

@estebanmino estebanmino changed the title [BLOCKED] Feature: implements method registry [BLOCKED] Feature: implement method registry Apr 1, 2019
@danfinlay

Copy link
Copy Markdown
Contributor

Published as eth-method-registry@1.1.0

@estebanmino estebanmino changed the title [BLOCKED] Feature: implement method registry Feature: implement method registry Apr 1, 2019
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #82   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1254   1273   +19     
  Branches      156    158    +2     
=====================================
+ Hits         1254   1273   +19
Impacted Files Coverage Δ
src/TransactionController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f358dd5...4f8b6cc. Read the comment docs.

@estebanmino
estebanmino merged commit 001d533 into master Apr 2, 2019
@estebanmino
estebanmino deleted the feature/method-registry branch April 2, 2019 14:17
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
* Update eslint and TypeScript configs, lint

* Update CI config

* Add test:nobuild command
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
* Return the whole error props obj instead of just type and message

* Add a test for the "mapKeysToCamel" fn
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants