Skip to content
This repository was archived by the owner on Nov 9, 2026. It is now read-only.
This repository was archived by the owner on Nov 9, 2026. It is now read-only.

signTypedData: uint and int fields should be forbidden #55

Open

Description

@cag

Right now, signTypedData will accept uint and int, but EIP 712 states that only integer types with their size are allowed.

Trying to use these should error, telling users that uint256 and int256 should be used instead when encountering these types.

Activity

  1. added this to the v4 milestone on Jul 20, 2021
  2. Gudahtt commented on Jul 20, 2021

    @Gudahtt
    Member

    Thanks for the report! I agree, but now that signTypedData has been out in the wild for a while, making this change might break dapps.

    We might bundle this with a fix for another spec incompatibility that was reported, and ship it as signTypedData_v5

  3. removed this from the v4 milestone on Jul 20, 2021
  4. added this to the signTypedData_v5 milestone on Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions