Skip to content

fix(stellar): separate scan errors - #608

Open
taran-a wants to merge 2 commits into
feat/stellar-security-scan-alignmentfrom
fix/stellar-separate-scan-errors
Open

taran-a wants to merge 2 commits into
feat/stellar-security-scan-alignmentfrom
fix/stellar-separate-scan-errors

Conversation

@taran-a

@taran-a taran-a commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Explanation

  • Simulation and security alerts now render side by side when both apply, instead of one hiding the other.
  • A blocking validation error still shows alone and takes precedence.
  • The "Security check unavailable" banner now depends on useSecurityAlerts. It no longer appears when security alerts are off.
  • Scan results get a separate validationError field, so a local validation failure isn't reported as a security scan failure.
  • Scan status is ERROR when requested validation didn't succeed, and SUCCESS otherwise.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@taran-a
taran-a requested a review from a team as a code owner November 15, 2026 16:42
@taran-a
taran-a requested review from a team as code owners November 15, 2026 16:42
@taran-a
taran-a force-pushed the fix/stellar-separate-scan-errors branch from bd1c4ef to 649d06d Compare November 15, 2026 16:43
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant