Repository navigation
chore(bitcoin): clean up integration test suppressions - #638
Merged
ulissesferreira merged 1 commit intoNov 17, 2026
Merged
Conversation
ulissesferreira
temporarily deployed
to
default-branch
November 17, 2026 02:29 — with
GitHub Actions
Inactive
ulissesferreira
enabled auto-merge
November 17, 2026 11:58
ulissesferreira
force-pushed
the
chore/bitcoin-lint-suppressions-integration-test
branch
from
November 17, 2026 14:45
6678571 to
1be59f9
Compare
ulissesferreira
force-pushed
the
chore/bitcoin-lint-suppressions-integration-test
branch
from
November 17, 2026 14:46
1be59f9 to
cb56a74
Compare
|
ulissesferreira
deleted the
chore/bitcoin-lint-suppressions-integration-test
branch
November 17, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes the 43 Oxlint suppressions recorded for
packages/bitcoin-wallet-snap/integration-test/**, so the whole directory is now lint-clean without entries inoxlint-suppressions.json. The changes are typing/hygiene only: redundantas KeyringRequestassertions are dropped (theparamsfield already accepts the object literal),inchecks becomehasProperty()from@metamask/utils,return undefinedfallbacks in thesnap.mockJsonRpchandlers are removed (an implicitundefinedis the same value), the untypedfetchJSON body inBlockchainTestUtils.getBalanceis given an explicit Esplora response type, and two dead.skiptests are deleted because the behaviour they exercised is gone:confirmSendno longer producesInsufficientBalanceToCoverFee(drainWallet covers the fee) andkeyring_createAccountno longer accepts P2PKH/P2SH/P2TR address types (KeyringHandler.createAccountsrejects everything but P2WPKH). No production code, lint config or rule severity was touched.Changes
packages/bitcoin-wallet-snap/integration-test/blockchain-utils.ts— dropimport process from 'process'(global), type the/address/:addressresponse (n/prefer-global/process,no-shadow,typescript/no-unsafe-argument,typescript/no-unsafe-member-access)packages/bitcoin-wallet-snap/integration-test/client-request.test.ts— drop the uselessreturn undefined, usehasPropertyfor the JSON-RPC result guard, remove the deadit.skipfee case and theas anyon the intentionally incompleteparams(unicorn/no-useless-undefined,vitest/no-disabled-tests,typescript/no-explicit-any,typescript/no-unnecessary-type-assertion,internal-snaps/no-in-operator)packages/bitcoin-wallet-snap/integration-test/cron-sync.test.ts— drop the uselessreturn undefined, usehasPropertyin the result assertion (unicorn/no-useless-undefined,internal-snaps/no-in-operator)packages/bitcoin-wallet-snap/integration-test/keyring-request.test.ts— drop 21 redundantas KeyringRequestcasts, drop the uselessreturn undefined, usehasProperty, andassert()the first UTXO instead of reading it through an optional chain (typescript/no-unnecessary-type-assertion×20,unicorn/no-useless-undefined,internal-snaps/no-in-operator)packages/bitcoin-wallet-snap/integration-test/keyring.test.ts— replace the conditional result guards withassert(hasProperty(...))so the setup runs unconditionally, drop the uselessreturn undefined, delete theit.skip.eachblock for unsupported address types (vitest/no-conditional-in-test×3,internal-snaps/no-in-operator×3,unicorn/no-useless-undefined,vitest/no-disabled-tests)oxlint-suppressions.json— regenerated with--prune-suppressions(5 file entries removed, 43 violations)Quality gates
yarn lint:oxlint packages/bitcoin-wallet-snap— clean, 43 of 43 suppressions entries removed (2069 → 2026 total counts)yarn workspace @metamask/bitcoin-wallet-snap exec tsc --project tsconfig.json --noEmit— cleanyarn workspace @metamask/bitcoin-wallet-snap exec vitest run— 28 files / 761 tests passedoxfmt --check— cleanintegration-test/run-integration.shboots bitcoind via@metamask/snaps-jest), so these files were validated withtsc+oxlintonly.