Skip to content

Commit 8b4d37e

Browse files
maxime-oeclaudemetamaskbot
authored
chore: bump assets-controller to ^20.3.0 and assets-controllers to ^13.3.0 (#47728)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump assets-controller to ^20.3.0 and assets-controllers to ^13.3.0 to fix prices on Matchain and Nomina ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/WPN-2474?atlOrigin=eyJpIjoiZTQwNjcwOWM4ZmI3NGM2OGJjNzdmMzVjYjNkNzVmZGEiLCJwIjoiaiJ9 ## **Manual testing steps** 1. For both Matchain and Nomina 2. Add the network as custom network 3. Check price for native token in assets list 4. Check price chart after clicking on native token ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="300" alt="image" src="https://github.com/user-attachments/assets/84d8f1af-9759-4afd-bf1f-02b2ebcf0187" /> <!-- [screenshots/recordings] --> ### **After** <img width="300" alt="image" src="https://github.com/user-attachments/assets/5e01e3c9-c015-4b76-a2f0-40bf3253e0a8" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches asset pricing paths and LavaMoat policies for all webpack build flavors; wrong policy entries could break builds or runtime sandboxing. > > **Overview** > Bumps **`@metamask/assets-controller`** to `^20.3.0` and **`@metamask/assets-controllers`** to `^113.3.0` (with lockfile refresh). The newer `assets-controllers` pulls **`@metamask/abi-utils` ^3.0.0** instead of a nested v2 copy. > > Across MV2/MV3 LavaMoat **`policy.json`** files, nested **`@metamask/assets-controllers>@metamask/abi-utils`** entries are dropped and **`@metamask/assets-controllers`** now grants **`@metamask/abi-utils`** directly—matching the updated dependency tree. > > Per the ticket, this is intended to **restore native token prices and charts on Matchain and Nomina** after adding those networks. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4627ea9. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
1 parent 14f4d1a commit 8b4d37e

10 files changed

Lines changed: 22 additions & 70 deletions

File tree

‎lavamoat/webpack/mv2/beta/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -788,12 +788,6 @@
788788
"@metamask/utils": true
789789
}
790790
},
791-
"@metamask/assets-controllers>@metamask/abi-utils": {
792-
"packages": {
793-
"@metamask/superstruct": true,
794-
"@metamask/utils": true
795-
}
796-
},
797791
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
798792
"packages": {
799793
"@metamask/superstruct": true,
@@ -937,7 +931,7 @@
937931
"ethers>@ethersproject/address": true,
938932
"@ethersproject/contracts": true,
939933
"@ethersproject/providers": true,
940-
"@metamask/assets-controllers>@metamask/abi-utils": true,
934+
"@metamask/abi-utils": true,
941935
"@metamask/base-controller": true,
942936
"@metamask/contract-metadata": true,
943937
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv2/experimental/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -788,12 +788,6 @@
788788
"@metamask/utils": true
789789
}
790790
},
791-
"@metamask/assets-controllers>@metamask/abi-utils": {
792-
"packages": {
793-
"@metamask/superstruct": true,
794-
"@metamask/utils": true
795-
}
796-
},
797791
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
798792
"packages": {
799793
"@metamask/superstruct": true,
@@ -937,7 +931,7 @@
937931
"ethers>@ethersproject/address": true,
938932
"@ethersproject/contracts": true,
939933
"@ethersproject/providers": true,
940-
"@metamask/assets-controllers>@metamask/abi-utils": true,
934+
"@metamask/abi-utils": true,
941935
"@metamask/base-controller": true,
942936
"@metamask/contract-metadata": true,
943937
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv2/flask/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -788,12 +788,6 @@
788788
"@metamask/utils": true
789789
}
790790
},
791-
"@metamask/assets-controllers>@metamask/abi-utils": {
792-
"packages": {
793-
"@metamask/superstruct": true,
794-
"@metamask/utils": true
795-
}
796-
},
797791
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
798792
"packages": {
799793
"@metamask/superstruct": true,
@@ -937,7 +931,7 @@
937931
"ethers>@ethersproject/address": true,
938932
"@ethersproject/contracts": true,
939933
"@ethersproject/providers": true,
940-
"@metamask/assets-controllers>@metamask/abi-utils": true,
934+
"@metamask/abi-utils": true,
941935
"@metamask/base-controller": true,
942936
"@metamask/contract-metadata": true,
943937
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv2/main/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -788,12 +788,6 @@
788788
"@metamask/utils": true
789789
}
790790
},
791-
"@metamask/assets-controllers>@metamask/abi-utils": {
792-
"packages": {
793-
"@metamask/superstruct": true,
794-
"@metamask/utils": true
795-
}
796-
},
797791
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
798792
"packages": {
799793
"@metamask/superstruct": true,
@@ -937,7 +931,7 @@
937931
"ethers>@ethersproject/address": true,
938932
"@ethersproject/contracts": true,
939933
"@ethersproject/providers": true,
940-
"@metamask/assets-controllers>@metamask/abi-utils": true,
934+
"@metamask/abi-utils": true,
941935
"@metamask/base-controller": true,
942936
"@metamask/contract-metadata": true,
943937
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv3/beta/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -992,12 +992,6 @@
992992
"@metamask/utils": true
993993
}
994994
},
995-
"@metamask/assets-controllers>@metamask/abi-utils": {
996-
"packages": {
997-
"@metamask/superstruct": true,
998-
"@metamask/utils": true
999-
}
1000-
},
1001995
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
1002996
"packages": {
1003997
"@metamask/superstruct": true,
@@ -1141,7 +1135,7 @@
11411135
"ethers>@ethersproject/address": true,
11421136
"@ethersproject/contracts": true,
11431137
"@ethersproject/providers": true,
1144-
"@metamask/assets-controllers>@metamask/abi-utils": true,
1138+
"@metamask/abi-utils": true,
11451139
"@metamask/base-controller": true,
11461140
"@metamask/contract-metadata": true,
11471141
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv3/experimental/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -992,12 +992,6 @@
992992
"@metamask/utils": true
993993
}
994994
},
995-
"@metamask/assets-controllers>@metamask/abi-utils": {
996-
"packages": {
997-
"@metamask/superstruct": true,
998-
"@metamask/utils": true
999-
}
1000-
},
1001995
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
1002996
"packages": {
1003997
"@metamask/superstruct": true,
@@ -1141,7 +1135,7 @@
11411135
"ethers>@ethersproject/address": true,
11421136
"@ethersproject/contracts": true,
11431137
"@ethersproject/providers": true,
1144-
"@metamask/assets-controllers>@metamask/abi-utils": true,
1138+
"@metamask/abi-utils": true,
11451139
"@metamask/base-controller": true,
11461140
"@metamask/contract-metadata": true,
11471141
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv3/flask/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -992,12 +992,6 @@
992992
"@metamask/utils": true
993993
}
994994
},
995-
"@metamask/assets-controllers>@metamask/abi-utils": {
996-
"packages": {
997-
"@metamask/superstruct": true,
998-
"@metamask/utils": true
999-
}
1000-
},
1001995
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
1002996
"packages": {
1003997
"@metamask/superstruct": true,
@@ -1141,7 +1135,7 @@
11411135
"ethers>@ethersproject/address": true,
11421136
"@ethersproject/contracts": true,
11431137
"@ethersproject/providers": true,
1144-
"@metamask/assets-controllers>@metamask/abi-utils": true,
1138+
"@metamask/abi-utils": true,
11451139
"@metamask/base-controller": true,
11461140
"@metamask/contract-metadata": true,
11471141
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎lavamoat/webpack/mv3/main/policy.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -992,12 +992,6 @@
992992
"@metamask/utils": true
993993
}
994994
},
995-
"@metamask/assets-controllers>@metamask/abi-utils": {
996-
"packages": {
997-
"@metamask/superstruct": true,
998-
"@metamask/utils": true
999-
}
1000-
},
1001995
"@metamask/gator-permissions-controller>@metamask/abi-utils": {
1002996
"packages": {
1003997
"@metamask/superstruct": true,
@@ -1141,7 +1135,7 @@
11411135
"ethers>@ethersproject/address": true,
11421136
"@ethersproject/contracts": true,
11431137
"@ethersproject/providers": true,
1144-
"@metamask/assets-controllers>@metamask/abi-utils": true,
1138+
"@metamask/abi-utils": true,
11451139
"@metamask/base-controller": true,
11461140
"@metamask/contract-metadata": true,
11471141
"@metamask/assets-controllers>@metamask/controller-utils": true,

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,8 +417,8 @@
417417
"@metamask/analytics-controller": "^4.1.0",
418418
"@metamask/announcement-controller": "^8.0.0",
419419
"@metamask/approval-controller": "^9.0.0",
420-
"@metamask/assets-controller": "^20.2.3",
421-
"@metamask/assets-controllers": "^113.2.0",
420+
"@metamask/assets-controller": "^20.3.0",
421+
"@metamask/assets-controllers": "^113.3.0",
422422
"@metamask/authenticated-user-storage": "^4.0.0",
423423
"@metamask/base-controller": "^10.0.0",
424424
"@metamask/base-data-service": "^2.1.0",

‎yarn.lock‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7390,16 +7390,16 @@ __metadata:
73907390
languageName: node
73917391
linkType: hard
73927392

7393-
"@metamask/assets-controller@npm:^20.0.1, @metamask/assets-controller@npm:^20.2.2, @metamask/assets-controller@npm:^20.2.3":
7394-
version: 20.2.3
7395-
resolution: "@metamask/assets-controller@npm:20.2.3"
7393+
"@metamask/assets-controller@npm:^20.0.1, @metamask/assets-controller@npm:^20.2.2, @metamask/assets-controller@npm:^20.3.0":
7394+
version: 20.3.0
7395+
resolution: "@metamask/assets-controller@npm:20.3.0"
73967396
dependencies:
73977397
"@ethereumjs/util": "npm:^9.1.0"
73987398
"@ethersproject/abi": "npm:^5.7.0"
73997399
"@ethersproject/providers": "npm:^5.8.0"
74007400
"@metamask/account-tree-controller": "npm:^11.2.0"
74017401
"@metamask/accounts-controller": "npm:^40.1.0"
7402-
"@metamask/assets-controllers": "npm:^113.2.0"
7402+
"@metamask/assets-controllers": "npm:^113.3.0"
74037403
"@metamask/base-controller": "npm:^10.1.0"
74047404
"@metamask/client-controller": "npm:^2.0.0"
74057405
"@metamask/config-registry-controller": "npm:^5.0.0"
@@ -7425,21 +7425,21 @@ __metadata:
74257425
async-mutex: "npm:^0.5.0"
74267426
bignumber.js: "npm:^9.1.2"
74277427
lodash-es: "npm:^4.18.1"
7428-
checksum: 10/9c083b848d17b37a2c831fd56466407a90bd3c7c418742de76d8f1b6bafc5e2e9ba5b7e05f326455559b0c1f01da4a8115e072290ffe9fdb706160ed09c781a8
7428+
checksum: 10/f21fcbe57eed1e0431d1584683b164e6156822c2b958623d67296e821ddd97d52e47a96ebb5496d9df7e79a8c2d10e4bb114eabdd9d725e9ccdd0b324b725442
74297429
languageName: node
74307430
linkType: hard
74317431

7432-
"@metamask/assets-controllers@npm:^113.0.0, @metamask/assets-controllers@npm:^113.2.0":
7433-
version: 113.2.0
7434-
resolution: "@metamask/assets-controllers@npm:113.2.0"
7432+
"@metamask/assets-controllers@npm:^113.0.0, @metamask/assets-controllers@npm:^113.3.0":
7433+
version: 113.3.0
7434+
resolution: "@metamask/assets-controllers@npm:113.3.0"
74357435
dependencies:
74367436
"@ethereumjs/util": "npm:^9.1.0"
74377437
"@ethersproject/abi": "npm:^5.7.0"
74387438
"@ethersproject/address": "npm:^5.8.0"
74397439
"@ethersproject/bignumber": "npm:^5.8.0"
74407440
"@ethersproject/contracts": "npm:^5.7.0"
74417441
"@ethersproject/providers": "npm:^5.8.0"
7442-
"@metamask/abi-utils": "npm:^2.0.4"
7442+
"@metamask/abi-utils": "npm:^3.0.0"
74437443
"@metamask/account-tree-controller": "npm:^11.2.0"
74447444
"@metamask/accounts-controller": "npm:^40.1.0"
74457445
"@metamask/approval-controller": "npm:^10.0.0"
@@ -7482,7 +7482,7 @@ __metadata:
74827482
peerDependencies:
74837483
"@metamask/providers": ^22.0.0
74847484
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
7485-
checksum: 10/c79851f7ebd75aa1691fa780711cefa41616572ddbb932ce491114e42a6a8f9c4a3badbbd691d8efd2de29898ea1fd241329123e1c4f3ee662afbec8d728cf18
7485+
checksum: 10/e7ba24a4fe8deb2dca8091c0876c4f97223a74bbe747d0b31ccfec4062d23f041c9a8aac4e7165a739bb3465cffd8bb0b5642c702989fba2282ad426fe2e7ca0
74867486
languageName: node
74877487
linkType: hard
74887488

@@ -35492,8 +35492,8 @@ __metadata:
3549235492
"@metamask/announcement-controller": "npm:^8.0.0"
3549335493
"@metamask/api-specs": "npm:^0.13.0"
3549435494
"@metamask/approval-controller": "npm:^9.0.0"
35495-
"@metamask/assets-controller": "npm:^20.2.3"
35496-
"@metamask/assets-controllers": "npm:^113.2.0"
35495+
"@metamask/assets-controller": "npm:^20.3.0"
35496+
"@metamask/assets-controllers": "npm:^113.3.0"
3549735497
"@metamask/authenticated-user-storage": "npm:^4.0.0"
3549835498
"@metamask/auto-changelog": "npm:^6.2.0"
3549935499
"@metamask/base-controller": "npm:^10.0.0"

0 commit comments

Comments
 (0)