Skip to content

chore: bump assets-controller to ^20.3.0 and assets-controllers to ^13.3.0 - #47728

Merged
maxime-oe merged 2 commits into
mainfrom
chore/bump-assets-controllers-113.3.0
Nov 9, 2026
Merged

maxime-oe merged 2 commits into
mainfrom
chore/bump-assets-controllers-113.3.0

Conversation

@maxime-oe

@maxime-oe maxime-oe commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry: bump assets-controller to ^20.3.0 and assets-controllers to ^13.3.0 to fix prices on Matchain and Nomina

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/WPN-2474?atlOrigin=eyJpIjoiZTQwNjcwOWM4ZmI3NGM2OGJjNzdmMzVjYjNkNzVmZGEiLCJwIjoiaiJ9

Manual testing steps

  1. For both Matchain and Nomina
  2. Add the network as custom network
  3. Check price for native token in assets list
  4. Check price chart after clicking on native token

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches asset pricing paths and LavaMoat policies for all webpack build flavors; wrong policy entries could break builds or runtime sandboxing.

Overview
Bumps @metamask/assets-controller to ^20.3.0 and @metamask/assets-controllers to ^113.3.0 (with lockfile refresh). The newer assets-controllers pulls @metamask/abi-utils ^3.0.0 instead of a nested v2 copy.

Across MV2/MV3 LavaMoat policy.json files, nested @metamask/assets-controllers>@metamask/abi-utils entries are dropped and @metamask/assets-controllers now grants @metamask/abi-utils directly—matching the updated dependency tree.

Per the ticket, this is intended to restore native token prices and charts on Matchain and Nomina after adding those networks.

Reviewed by Cursor Bugbot for commit 4627ea9. Bugbot is set up for automated code reviews on this repo. Configure here.

…13.3.0

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​assets-controller@​20.2.3 ⏵ 20.3.098 +110080 +1100 +1100
Updated@​metamask/​assets-controllers@​113.2.0 ⏵ 113.3.098 +110091 +1100 +1100

View full report

@maxime-oe
maxime-oe marked this pull request as ready for review November 9, 2026 11:32
@maxime-oe

Copy link
Copy Markdown
Contributor Author

@metamaskbot update policies

@maxime-oe

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@metamask-ci
metamask-ci Bot requested a review from a team as a code owner November 9, 2026 11:46
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +8 -56)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +1 -7
        • 📁 experimental/
          • 📄 policy.json +1 -7
        • 📁 flask/
          • 📄 policy.json +1 -7
        • 📁 main/
          • 📄 policy.json +1 -7
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +1 -7
        • 📁 experimental/
          • 📄 policy.json +1 -7
        • 📁 flask/
          • 📄 policy.json +1 -7
        • 📁 main/
          • 📄 policy.json +1 -7

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4627ea9]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42611674661 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +863%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +63%
  • ↑ confirmTx/longTaskMaxDuration: +49%
  • ↑ confirmTx/tbt: +65%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +922%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +138%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +43%
  • ↑ bridgeUserActions/tbt: +13%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/lcp: +863%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1701%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -32%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +213%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +233%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +1256%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 3.2s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +67%
  • ↑ startupStandardHome/domContentLoaded: +68%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +66%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +64%
  • ↑ startupStandardHome/longTaskMaxDuration: +75%
  • ↑ startupStandardHome/tbt: +78%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -60%
  • ↑ startupStandardHome/lcp: +78%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -44%
  • ↓ startupStandardHome/load: -41%
  • ↓ startupStandardHome/domContentLoaded: -42%
  • ↓ startupStandardHome/domInteractive: -60%
  • ↓ startupStandardHome/backgroundConnect: -41%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -41%
  • ↓ startupStandardHome/setupStore: -41%
  • ↓ startupStandardHome/fcp: -52%
  • ↓ startupStandardHome/lcp: -40%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +13%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +29%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -88%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -26%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.23 MiB -23.17 KiB -0.15%
✅ ui 19.42 MiB -122 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -334 Bytes -0.01%
✅ content scripts 3.23 MiB -668 Bytes -0.02%
✅ unzipped 79.75 MiB -24.26 KiB -0.03%
✅ zip 23.86 MiB -931 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@maxime-oe maxime-oe changed the title chore: bump assets-controller to ^20.3.0 and assets-controllers to ^1… chore: bump assets-controller to ^20.3.0 and assets-controllers to ^13.3.0 Nov 9, 2026
@maxime-oe

Copy link
Copy Markdown
Contributor Author

Policies updated. 👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes 👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes 👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

The only additions I can see are:

        "@metamask/abi-utils": true,

But they come as a replacement for:

        "@metamask/assets-controllers>@metamask/abi-utils": true,

Therefore I don't believe the new policy involve extra risk compared to the old ones. This is just my interpretation.

@Battambang Battambang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@FrederikBolding FrederikBolding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy lgtm

@maxime-oe
maxime-oe added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 8b4d37e Nov 9, 2026
146 checks passed
@maxime-oe
maxime-oe deleted the chore/bump-assets-controllers-113.3.0 branch November 9, 2026 14:35
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS team-emerging-opportunities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants