Skip to content

Commit c35cd6d

Browse files
revert: remove draft Segment schema PR workflow (#46897)" (#47788)
This reverts commit c2b35df. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Removing this non working workflow ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-1139 ## **Manual testing steps** NA ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > CI-only deletion with no runtime or product code impact; Segment schema PRs will no longer be automated until a replacement exists. > > **Overview** > Reverts the **draft Segment schema PR** GitHub Actions automation by deleting the workflow and its **actionlint** overrides. > > This removes `.github/workflows/draft-segment-schema-pr.yml`, which had triggered on Segment-related UI/script changes and on author opt-in comments to propose, create, or close companion PRs in `Consensys/segment-schema` via a GitHub App token. It also removes `.github/actionlint.yaml`, which had suppressed lint warnings for `client-id` on `actions/create-github-app-token@v3` in that workflow. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4b3cbf0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 0846982 commit c35cd6d

2 files changed

Lines changed: 0 additions & 184 deletions

File tree

‎.github/actionlint.yaml‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎.github/workflows/draft-segment-schema-pr.yml‎

Lines changed: 0 additions & 176 deletions
This file was deleted.

0 commit comments

Comments
 (0)