Skip to content

feat: add draft Segment schema PR workflow - #46897

Merged
NicolasMassart merged 19 commits into
mainfrom
feat/mcwp-575-draft-segment-schema-pr
Oct 23, 2026
Merged

NicolasMassart merged 19 commits into
mainfrom
feat/mcwp-575-draft-segment-schema-pr

Conversation

@NicolasMassart

@NicolasMassart NicolasMassart commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds a helper workflow that reads analytics TypeScript changes on a pull request and can open one draft pull request on Consensys/segment-schema after the author agrees. It is not a merge gate.

The action is pinned to github-tools v1.21.0 (5d993ac935eff3f248d2213bb2d6922ce9cb3510). propose and close run for changes under ui/, app/scripts/, or shared/constants/metametrics.ts, excluding tests and snapshots. create runs only after this file is on the default branch.

Changelog

CHANGELOG entry: null

Related issues

Fixes MCWP-911
related to MCWP-575
Shipped in github-tools v1.21.0.

Manual testing steps

This pull request only adds a workflow file, so propose does not run here.

After merge:

  1. Open a ready, same-repo pull request that changes a non-test file under ui/ or app/scripts/, or shared/constants/metametrics.ts, and includes an analytics event change.
  2. Confirm the propose job posts one sticky comment and does not open a schema pull request yet.
  3. As the pull request author, comment with the first line I agree to open a draft Segment schema PR.
  4. Confirm did-user-agree-to-create-pr, then is-cross-repo-pr, then create open one draft on Consensys/segment-schema.
  5. Close the client pull request without merging and confirm the schema draft is closed. Reopen that schema pull request manually if the branch should be kept.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Introduces GitHub App credentials and cross-repo PR writes to segment-schema, but creation is author opt-in and gated by labels, fork checks, and protected environments—not a merge blocker.

Reviewed by Cursor Bugbot for commit d929f01. Bugbot is set up for automated code reviews on this repo. Configure here.

Propose, create, and close a Consensys/segment-schema draft from analytics TypeScript changes after the author agrees.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Remove DraftSchemaPrWorkflowTest before merging this pull request.

Co-authored-by: Cursor <cursoragent@cursor.com>
@NicolasMassart NicolasMassart added the DO-NOT-MERGE Pull requests that should not be merged label Oct 6, 2026
@NicolasMassart
NicolasMassart marked this pull request as ready for review October 6, 2026 14:49

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread shared/constants/metametrics.ts Resolved
GitHub rejects paths and paths-ignore on the same pull_request event, so the workflow never queued.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@metamask-ci

metamask-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5f8241a]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 37641185838 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +411%
  • ↑ loadNewAccount/total: +411%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -34%
  • ↓ loadNewAccount/lcp: -25%
  • ↓ confirmTx/tbt: -14%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -35%
  • ↓ confirmTx/lcp: -25%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -27%
  • ↓ bridgeUserActions/bridge_search_token: -13%
  • ↓ bridgeUserActions/longTaskCount: -44%
  • ↓ bridgeUserActions/longTaskTotalDuration: -59%
  • ↓ bridgeUserActions/longTaskMaxDuration: -36%
  • ↓ bridgeUserActions/tbt: -86%
  • ↓ bridgeUserActions/total: -15%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -36%
  • ↓ bridgeUserActions/lcp: -34%
  • ↑ loadNewAccount/load_new_account: +413%
  • ↑ loadNewAccount/total: +413%
  • ↓ loadNewAccount/inp: -47%
  • ↓ loadNewAccount/fcp: -83%
  • ↑ loadNewAccount/lcp: +953%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -78%
  • ↑ confirmTx/lcp: +712%
  • ↑ bridgeUserActions/bridge_load_page: +113%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +26%
  • ↓ bridgeUserActions/bridge_search_token: -13%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -81%
  • ↑ bridgeUserActions/lcp: +822%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +74%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -25%
  • ↓ startupStandardHome/load: -19%
  • ↓ startupStandardHome/domContentLoaded: -19%
  • ↓ startupStandardHome/domInteractive: -44%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -19%
  • ↑ startupStandardHome/setupStore: +94%
  • ↓ startupStandardHome/fcp: -37%
  • ↓ startupStandardHome/lcp: -17%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -15%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -11%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -23%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +45%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +30%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -42%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -56%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.56 MiB +249 Bytes 0.00%
✅ ui 19.01 MiB -134 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 1.69 MiB 0 Bytes 0.00%
✅ content scripts 1.98 MiB 0 Bytes 0.00%
✅ zip 22.8 MiB +8 Bytes 0.00%

Schema reads and writes use this token, so it must be that installation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f2cb34d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 37651035491 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +71%
  • ↑ confirmTx/tbt: +83%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +38%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +15%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +98%
  • ↑ bridgeUserActions/longTaskMaxDuration: +27%
  • ↑ bridgeUserActions/tbt: +166%
  • ↑ loadNewAccount/load_new_account: +415%
  • ↑ loadNewAccount/total: +415%
  • ↓ loadNewAccount/fcp: -78%
  • ↑ loadNewAccount/lcp: +837%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -73%
  • ↑ confirmTx/lcp: +767%
  • ↑ bridgeUserActions/bridge_load_page: +160%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +89%
  • ↓ bridgeUserActions/bridge_search_token: -14%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +14%
  • ↓ bridgeUserActions/fcp: -71%
  • ↑ bridgeUserActions/lcp: +795%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -18%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/domInteractive: -20%
  • ↓ startupStandardHome/firstPaint: -13%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +14%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -26%
  • ↓ startupStandardHome/longTaskMaxDuration: -19%
  • ↓ startupStandardHome/tbt: -24%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -17%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -21%
  • ↓ startupStandardHome/domContentLoaded: -20%
  • ↓ startupStandardHome/domInteractive: -49%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +110%
  • ↓ startupStandardHome/fcp: -35%
  • ↓ startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +41%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +51%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +30%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +25%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -16%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -18%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -22%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.56 MiB +249 Bytes 0.00%
✅ ui 19.01 MiB -134 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 1.69 MiB 0 Bytes 0.00%
✅ content scripts 1.98 MiB 0 Bytes 0.00%
✅ zip 22.8 MiB +8 Bytes 0.00%

actionlint 1.7.12 checks create-github-app-token for app-id. This workflow uses client-id.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2096b79] [reused from 731673e]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 38734741292 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -17%
  • ↓ loadNewAccount/lcp: -14%
  • ↑ confirmTx/longTaskTotalDuration: +34%
  • ↑ confirmTx/longTaskMaxDuration: +57%
  • ↑ confirmTx/tbt: +60%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -15%
  • ↑ bridgeUserActions/bridge_load_page: +24%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +75%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +56%
  • ↑ bridgeUserActions/tbt: +39%
  • ↓ bridgeUserActions/fcp: -18%
  • ↓ bridgeUserActions/lcp: -16%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -60%
  • ↑ loadNewAccount/lcp: +1327%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -50%
  • ↑ confirmTx/lcp: +1405%
  • ↑ bridgeUserActions/bridge_load_page: +301%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +29%
  • ↑ bridgeUserActions/inp: +46%
  • ↓ bridgeUserActions/fcp: -47%
  • ↑ bridgeUserActions/lcp: +1227%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +21%
  • ↑ startupStandardHome/firstPaint: +15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +195%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +18%
  • ↓ startupStandardHome/domInteractive: -41%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +153%
  • ↓ startupStandardHome/fcp: -35%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +54%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +45%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +37%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -63%
  • ↓ dappPageLoad/domContentLoaded: -14%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.39 MiB 0 Bytes 0.00%
✅ ui 19.23 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.35 MiB 0 Bytes 0.00%
✅ content scripts 3.15 MiB 0 Bytes 0.00%
✅ zip 23.85 MiB 0 Bytes 0.00%

create minted the App token from the agreement comment alone, including when the client PR was closed or labeled no-schema-pr.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Builds ready [602bf69] [reused from f1a2598]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 1 warn · 🔴 0 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 38756873485 | Baseline logs

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions, firefox/webpack/interactionUserActions

✅ No regressions detected

Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, firefox/webpack/startupStandardHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +38%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -19%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -31%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -23%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.39 MiB 0 Bytes 0.00%
✅ ui 19.25 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.35 MiB 0 Bytes 0.00%
✅ content scripts 3.15 MiB 0 Bytes 0.00%
✅ zip 23.91 MiB 0 Bytes 0.00%

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 602bf69. Configure here.

actionlint flags separate redirects to GITHUB_OUTPUT.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3e43335]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 38761483937 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -17%
  • ↑ confirmTx/longTaskTotalDuration: +49%
  • ↑ confirmTx/longTaskMaxDuration: +79%
  • ↑ confirmTx/tbt: +88%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +117%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +36%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +146%
  • ↑ bridgeUserActions/longTaskMaxDuration: +53%
  • ↑ bridgeUserActions/tbt: +309%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -39%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1290%
  • ↑ bridgeUserActions/bridge_load_page: +310%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +30%
  • ↑ bridgeUserActions/inp: +46%
  • ↓ bridgeUserActions/fcp: -49%
  • ↑ bridgeUserActions/lcp: +1310%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -13%
  • ↓ startupStandardHome/load: -15%
  • ↓ startupStandardHome/domContentLoaded: -15%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +135%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -24%
  • ↓ startupStandardHome/longTaskMaxDuration: -19%
  • ↓ startupStandardHome/tbt: -22%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -16%
  • ↓ startupStandardHome/domInteractive: -27%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +163%
  • ↓ startupStandardHome/fcp: -21%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +47%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +37%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +28%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +47%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +34%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +29%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -58%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -47%
  • ↓ onboardingNewWallet/tbt: -94%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.39 MiB +2.52 KiB +0.02%
🚨 ui 19.25 MiB +24.55 KiB +0.12%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.35 MiB +75 Bytes 0.00%
✅ content scripts 3.15 MiB +150 Bytes 0.00%
🚨 zip 23.91 MiB +66.03 KiB +0.27%

@sonarqubecloud

Copy link
Copy Markdown

The action is released, so the workflow uses that commit instead of the pre-release pin.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d929f01] [reused from 3fe977d]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39789245743 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -15%
  • ↓ loadNewAccount/lcp: -15%
  • ↑ confirmTx/longTaskTotalDuration: +20%
  • ↑ confirmTx/longTaskMaxDuration: +51%
  • ↑ confirmTx/tbt: +36%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +29%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +75%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +51%
  • ↓ bridgeUserActions/longTaskMaxDuration: -12%
  • ↑ bridgeUserActions/tbt: +23%
  • ↓ bridgeUserActions/fcp: -15%
  • ↓ bridgeUserActions/lcp: -14%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/inp: +29%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1316%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +30%
  • ↑ confirmTx/lcp: +1381%
  • ↑ bridgeUserActions/bridge_load_page: +420%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +201%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1319%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +97%
  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -31%
  • ↓ startupStandardHome/domContentLoaded: -31%
  • ↓ startupStandardHome/domInteractive: -52%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -31%
  • ↑ startupStandardHome/setupStore: +45%
  • ↓ startupStandardHome/fcp: -37%
  • ↓ startupStandardHome/lcp: -28%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -13%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -10%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -15%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -19%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -30%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -91%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -87%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.47 MiB 0 Bytes 0.00%
✅ ui 19.34 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.24 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB 0 Bytes 0.00%

@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Oct 23, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Oct 23, 2026
@NicolasMassart
NicolasMassart added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit c2b35df Oct 23, 2026
52 of 54 checks passed
@NicolasMassart
NicolasMassart deleted the feat/mcwp-575-draft-segment-schema-pr branch October 23, 2026 11:07
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2026
@NicolasMassart NicolasMassart removed the DO-NOT-MERGE Pull requests that should not be merged label Oct 23, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026

This branch was previously deployed

2 inactive (1 outdated) deployments
pr-comment — d929f01d Deployed Oct 22, 2026 by NicolasMassart via Publish prerelease / Publish prerelease #170748
segment-schema — 72d86dd9 Deployed Oct 15, 2026 by NicolasMassart via propose #15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants