Skip to content

Commit e4e3333

Browse files
chore(settings): remove unused settings-page class selectors (#47676)
## **Description** Removes unused class selectors from `ui/pages/settings/index.scss`. Owner set: `@MetaMask/core-extension-ux`. No component, HTML file, test, snapshot, story, or e2e selector applies these classes, and no stylesheet `@extend`s them. `.settings-page__content-item` itself is still applied and is kept, along with its `.dialog` child rule. | path | removed | why dead | | --- | --- | --- | | `ui/pages/settings/index.scss` | `.settings-page__back-button` (incl. RTL rule) | unused class selector | | `ui/pages/settings/index.scss` | `.settings-page__content-item--without-height`, `--disabled` | unused class selector | | `ui/pages/settings/index.scss` | `.settings-page__content-item__title`, `__identicon`, `__description` | unused class selector | No user-facing behavior change. Checks: `yarn lint:styles`, Sass compile of the file, `yarn test:unit --coverage=false ui/pages/settings` (no snapshot updates). No JS/TS changed, so `yarn lint:tsc` and ESLint were not needed. Docs/comments updated: none ## **Changelog** CHANGELOG entry: null ## **Related issues** Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948) ## **Manual testing steps** N/A — deletes unreachable code. There is no user-facing behavior to click through. ## **Screenshots/Recordings** N/A — no UI change ### **Before** N/A — no UI change ### **After** N/A — no UI change ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Stylesheet-only deletion of unused selectors; no JS/TS or markup changes. > > **Overview** > Removes **dead SCSS** from `ui/pages/settings/index.scss` with no runtime or visual impact. > > Deleted selectors include `.settings-page__back-button` (including its RTL margin/rotation rules), unused `.settings-page__content-item` modifiers (`--without-height`, `--disabled`), and nested BEM blocks (`__title`, `__identicon`, `__description`). **Kept** rules for `.settings-page__content-item` itself and its `.dialog` child spacing. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 104690b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
1 parent 414c75f commit e4e3333

1 file changed

Lines changed: 0 additions & 36 deletions

File tree

‎ui/pages/settings/index.scss‎

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,6 @@
2424
}
2525
}
2626

27-
&__back-button {
28-
margin-right: 8px;
29-
30-
[dir='rtl'] & {
31-
margin: 0 0 0 8px;
32-
transform: rotate(180deg);
33-
}
34-
}
35-
3627
&__body {
3728
padding: 0 16px 16px 16px;
3829
}
@@ -54,36 +45,9 @@
5445
height: initial;
5546
}
5647

57-
&--without-height {
58-
height: initial;
59-
}
60-
61-
&--disabled {
62-
cursor: not-allowed;
63-
opacity: 0.5;
64-
}
65-
6648
& .dialog {
6749
margin-top: 10px;
6850
}
69-
70-
&__title {
71-
font-size: 14px;
72-
font-weight: 500;
73-
line-height: 22px;
74-
}
75-
76-
&__identicon {
77-
display: flex;
78-
flex-direction: row;
79-
align-items: baseline;
80-
}
81-
82-
&__description {
83-
@include design-system.H6;
84-
85-
line-height: 22px;
86-
}
8751
}
8852

8953
&__content-description {

0 commit comments

Comments
 (0)