Repository navigation
chore(settings): remove unused settings-page class selectors - #47676
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Merged
georgewrmarshall merged 1 commit into
georgewrmarshall merged 1 commit into
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:34 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +0 -36)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:47 — with
GitHub Actions
Inactive
Contributor
Builds ready [104690b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
georgewrmarshall
marked this pull request as ready for review
November 5, 2026 23:14
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 23:14 — with
GitHub Actions
Inactive
georgewrmarshall
enabled auto-merge
November 5, 2026 23:14
n3ps
approved these changes
Nov 6, 2026
AndyMBridges
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-settings-class-selectors-20261105-7b9e
branch
November 6, 2026 16:36
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes unused class selectors from
ui/pages/settings/index.scss. Owner set:@MetaMask/core-extension-ux.No component, HTML file, test, snapshot, story, or e2e selector applies these classes, and no stylesheet
@extends them..settings-page__content-itemitself is still applied and is kept, along with its.dialogchild rule.ui/pages/settings/index.scss.settings-page__back-button(incl. RTL rule)ui/pages/settings/index.scss.settings-page__content-item--without-height,--disabledui/pages/settings/index.scss.settings-page__content-item__title,__identicon,__descriptionNo user-facing behavior change.
Checks:
yarn lint:styles, Sass compile of the file,yarn test:unit --coverage=false ui/pages/settings(no snapshot updates). No JS/TS changed, soyarn lint:tscand ESLint were not needed.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Stylesheet-only deletion of unused selectors; no JS/TS or markup changes.
Overview
Removes dead SCSS from
ui/pages/settings/index.scsswith no runtime or visual impact.Deleted selectors include
.settings-page__back-button(including its RTL margin/rotation rules), unused.settings-page__content-itemmodifiers (--without-height,--disabled), and nested BEM blocks (__title,__identicon,__description). Kept rules for.settings-page__content-itemitself and its.dialogchild spacing.Reviewed by Cursor Bugbot for commit 104690b. Bugbot is set up for automated code reviews on this repo. Configure here.