Skip to content

chore(settings): remove unused settings-page class selectors - #47676

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-settings-class-selectors-20261105-7b9e
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-settings-class-selectors-20261105-7b9e

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes unused class selectors from ui/pages/settings/index.scss. Owner set: @MetaMask/core-extension-ux.

No component, HTML file, test, snapshot, story, or e2e selector applies these classes, and no stylesheet @extends them. .settings-page__content-item itself is still applied and is kept, along with its .dialog child rule.

path removed why dead
ui/pages/settings/index.scss .settings-page__back-button (incl. RTL rule) unused class selector
ui/pages/settings/index.scss .settings-page__content-item--without-height, --disabled unused class selector
ui/pages/settings/index.scss .settings-page__content-item__title, __identicon, __description unused class selector

No user-facing behavior change.

Checks: yarn lint:styles, Sass compile of the file, yarn test:unit --coverage=false ui/pages/settings (no snapshot updates). No JS/TS changed, so yarn lint:tsc and ESLint were not needed.

Docs/comments updated: none

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A — no UI change

After

N/A — no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Stylesheet-only deletion of unused selectors; no JS/TS or markup changes.

Overview
Removes dead SCSS from ui/pages/settings/index.scss with no runtime or visual impact.

Deleted selectors include .settings-page__back-button (including its RTL margin/rotation rules), unused .settings-page__content-item modifiers (--without-height, --disabled), and nested BEM blocks (__title, __identicon, __description). Kept rules for .settings-page__content-item itself and its .dialog child spacing.

Reviewed by Cursor Bugbot for commit 104690b. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@github-actions github-actions Bot added the size-S label Nov 5, 2026
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed size-S labels Nov 5, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +0 -36)
  • 📁 ui/
    • 📁 pages/
      • 📁 settings/
        • 📄 index.scss +0 -36

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [104690b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42104595910 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +947%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +51%
  • ↑ confirmTx/longTaskMaxDuration: +51%
  • ↑ confirmTx/tbt: +66%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +987%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +117%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +56%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +114%
  • ↑ bridgeUserActions/longTaskMaxDuration: +36%
  • ↑ bridgeUserActions/tbt: +197%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +32%
  • ↑ bridgeUserActions/lcp: +968%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/inp: +101%
  • ↓ loadNewAccount/fcp: -62%
  • ↑ loadNewAccount/lcp: +1073%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -74%
  • ↑ confirmTx/lcp: +1154%
  • ↑ bridgeUserActions/bridge_load_page: +165%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +148%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +32%
  • ↑ bridgeUserActions/inp: +121%
  • ↓ bridgeUserActions/fcp: -10%
  • ↑ bridgeUserActions/lcp: +1047%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/INP: p75 216ms
  • 🟡 bridgeUserActions/INP: p75 240ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/load: +22%
  • ↑ startupStandardHome/domContentLoaded: +22%
  • ↓ startupStandardHome/domInteractive: -23%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -36%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +21%
  • ↑ startupStandardHome/setupStore: +17%
  • ↑ startupStandardHome/longTaskTotalDuration: +18%
  • ↑ startupStandardHome/longTaskMaxDuration: +43%
  • ↑ startupStandardHome/tbt: +27%
  • ↓ startupStandardHome/inp: -43%
  • ↑ startupStandardHome/fcp: +21%
  • ↑ startupStandardHome/lcp: +443%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -41%
  • ↓ startupStandardHome/load: -37%
  • ↓ startupStandardHome/domContentLoaded: -39%
  • ↓ startupStandardHome/domInteractive: -58%
  • ↓ startupStandardHome/backgroundConnect: -37%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -37%
  • ↑ startupStandardHome/setupStore: +41%
  • ↓ startupStandardHome/fcp: -44%
  • ↓ startupStandardHome/lcp: -37%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -12%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -16%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +25%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -65%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -71%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -31%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -61%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -31%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +116 Bytes 0.00%
✅ ui 19.4 MiB -3.94 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -14 Bytes 0.00%
✅ content scripts 3.23 MiB -28 Bytes 0.00%
✅ unzipped 79.73 MiB -4.64 KiB -0.01%
✅ zip 23.85 MiB -1.34 KiB -0.01%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall marked this pull request as ready for review November 5, 2026 23:14
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 5, 2026 23:14
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit e4e3333 Nov 6, 2026
268 of 274 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-settings-class-selectors-20261105-7b9e branch November 6, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 104690b2 Deployed Nov 5, 2026 by georgewrmarshall via identify-codeowners #88861
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.58.0 Issue or pull request that will be included in release 13.58.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants