Repository navigation
Commit f693520
chore(ui): activity details as modal on wide viewport (#47309)
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**
This PR makes the Activity Details dialog look like a proper modal on
wide viewports while preserving the current full-screen appearance on
narrow sized viewports.
The goal is to serve as reference for future componetization of this
pattern, to be used in wide layouts
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Prepares for full-screen layout work by @amelieyc
## **Manual testing steps**
**Testing on wide viewport (desktop browser):**
1. Build and run the extension in a desktop browser (Chrome/Brave/Edge)
2. Open MetaMask and navigate to the Activity tab
3. Click on any transaction in the activity list to open the details
dialog
4. Verify the dialog appears as a centered modal
5. Click outside the dialog or press Escape to close it
**Testing on narrow viewport (popup/sidepanel):**
1. Open the extension
2. Navigate to the Activity tab
3. Click on any transaction to open the details
4. Verify the dialog appears full-screen (same as before this PR)
## **Screenshots/Recordings**
<!--
I was unable to capture before/after screenshots because the development
build
was not running during PR creation. The build is managed externally per
repo
policy. Visual verification should be performed during review using the
manual
testing steps above.
-->
### **Before**
N/A - No screenshots available (build not running during PR creation)
### **After**
N/A - No screenshots available (build not running during PR creation)
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable (existing tests pass, no new
tests needed for styling change)
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable (no new functions added)
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-a5e61e3e-8ab0-5920-af69-0ce80c3b7f50?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-a5e61e3e-8ab0-5920-af69-0ce80c3b7f50&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Responsive styling and dialog UX only; no auth, routing logic, or
data-handling changes beyond existing dialog open/close behavior.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
179ee4f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>1 parent d71a407 commit f693520
3 files changed
Lines changed: 16 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
| 238 | + | |
239 | 239 | | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
240 | 243 | | |
241 | 244 | | |
242 | 245 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
0 commit comments